patch 'net/hns3: fix VF mailbox message handling' has been queued to stable release 20.11.7
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Nov 3 10:27:48 CET 2022
Hi,
FYI, your patch has been queued to stable release 20.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/05/22. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/c24c705ee88adc9bf573c01443a2d2f0818721c0
Thanks.
Luca Boccassi
---
>From c24c705ee88adc9bf573c01443a2d2f0818721c0 Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Fri, 30 Sep 2022 15:22:19 +0800
Subject: [PATCH] net/hns3: fix VF mailbox message handling
[ upstream commit bc6eeb29c64e9eda1862dd8410eb9f49cc42e77a ]
VF's command receive queue was mainly used to receive mailbox messages
from PF. There are two type mailbox messages: request response message
and message pushed by PF.
There are two types of threads that can handle these messages:
1) the interrupt thread of the main process: it could handle both types
of messages.
2) other threads: it could only handle request response messages.
The collaboration mechanism between the two type threads is that other
threads set the opcode of processed messages to zero so that the
interrupt thread of the main process does not process these messages
again.
Unfortunately, the other threads mark the message pointed to by the
crq->next-to-use variable which is fixed in the loop, not the message
pointed to by the next-to-use variable.
Fixes: dbbbad23e380 ("net/hns3: fix VF handling LSC event in secondary process")
Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3 at huawei.com>
---
drivers/net/hns3/hns3_mbx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c
index e8d336f516..63ec11b838 100644
--- a/drivers/net/hns3/hns3_mbx.c
+++ b/drivers/net/hns3/hns3_mbx.c
@@ -435,7 +435,7 @@ hns3_handle_mbx_msg_out_intr(struct hns3_hw *hw)
* Clear opcode to inform intr thread don't process
* again.
*/
- crq->desc[crq->next_to_use].opcode = 0;
+ crq->desc[next_to_use].opcode = 0;
}
scan_next:
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2022-11-03 09:27:30.973946177 +0000
+++ 0090-net-hns3-fix-VF-mailbox-message-handling.patch 2022-11-03 09:27:25.549425848 +0000
@@ -1 +1 @@
-From bc6eeb29c64e9eda1862dd8410eb9f49cc42e77a Mon Sep 17 00:00:00 2001
+From c24c705ee88adc9bf573c01443a2d2f0818721c0 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit bc6eeb29c64e9eda1862dd8410eb9f49cc42e77a ]
+
@@ -25 +26,0 @@
-Cc: stable at dpdk.org
@@ -34 +35 @@
-index 910a16c999..8e0a58aa02 100644
+index e8d336f516..63ec11b838 100644
@@ -37 +38 @@
-@@ -429,7 +429,7 @@ hns3_handle_mbx_msg_out_intr(struct hns3_hw *hw)
+@@ -435,7 +435,7 @@ hns3_handle_mbx_msg_out_intr(struct hns3_hw *hw)
More information about the stable
mailing list