patch 'baseband/acc100: fix close cleanup' has been queued to stable release 21.11.3
Kevin Traynor
ktraynor at redhat.com
Fri Nov 11 11:33:33 CET 2022
Hi,
FYI, your patch has been queued to stable release 21.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/14/22. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/c6b2befc2e3b11ba9bc9bad74bda285b3d2c4b3a
Thanks.
Kevin
---
>From c6b2befc2e3b11ba9bc9bad74bda285b3d2c4b3a Mon Sep 17 00:00:00 2001
From: Hernan Vargas <hernan.vargas at intel.com>
Date: Thu, 20 Oct 2022 22:20:46 -0700
Subject: [PATCH] baseband/acc100: fix close cleanup
[ upstream commit ba2262fe16cade81a18b353d580ec4229e1020a6 ]
Set local pointer to NULL after rte_free.
This needs to be set explicitly since logic may check for null pointers.
Fixes: 060e7672930 ("baseband/acc100: add queue configuration")
Signed-off-by: Hernan Vargas <hernan.vargas at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
drivers/baseband/acc100/rte_acc100_pmd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
index 00c31fe85b..b59548315f 100644
--- a/drivers/baseband/acc100/rte_acc100_pmd.c
+++ b/drivers/baseband/acc100/rte_acc100_pmd.c
@@ -770,4 +770,7 @@ acc100_dev_close(struct rte_bbdev *dev)
rte_free(d->sw_rings_base);
d->sw_rings_base = NULL;
+ d->tail_ptrs = NULL;
+ d->info_ring = NULL;
+ d->harq_layout = NULL;
}
/* Ensure all in flight HW transactions are completed */
--
2.38.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2022-11-11 10:32:18.081362518 +0000
+++ 0043-baseband-acc100-fix-close-cleanup.patch 2022-11-11 10:32:17.124300970 +0000
@@ -1 +1 @@
-From ba2262fe16cade81a18b353d580ec4229e1020a6 Mon Sep 17 00:00:00 2001
+From c6b2befc2e3b11ba9bc9bad74bda285b3d2c4b3a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit ba2262fe16cade81a18b353d580ec4229e1020a6 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -15 +16 @@
- drivers/baseband/acc/rte_acc100_pmd.c | 3 +++
+ drivers/baseband/acc100/rte_acc100_pmd.c | 3 +++
@@ -18,5 +19,5 @@
-diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
-index a711862892..ad815ed76a 100644
---- a/drivers/baseband/acc/rte_acc100_pmd.c
-+++ b/drivers/baseband/acc/rte_acc100_pmd.c
-@@ -619,4 +619,7 @@ acc100_dev_close(struct rte_bbdev *dev)
+diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
+index 00c31fe85b..b59548315f 100644
+--- a/drivers/baseband/acc100/rte_acc100_pmd.c
++++ b/drivers/baseband/acc100/rte_acc100_pmd.c
+@@ -770,4 +770,7 @@ acc100_dev_close(struct rte_bbdev *dev)
More information about the stable
mailing list