patch 'test/hash: fix bulk lookup check' has been queued to stable release 20.11.7
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Fri Nov 18 00:08:35 CET 2022
Hi,
FYI, your patch has been queued to stable release 20.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/19/22. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/0053fb1fe8feb7be4f06f5097095f2cb4967938e
Thanks.
Luca Boccassi
---
>From 0053fb1fe8feb7be4f06f5097095f2cb4967938e Mon Sep 17 00:00:00 2001
From: Vladimir Medvedkin <vladimir.medvedkin at intel.com>
Date: Thu, 3 Nov 2022 18:52:56 +0000
Subject: [PATCH] test/hash: fix bulk lookup check
[ upstream commit 521171cf2a3cbc108ec920874cfa3706e7f89c73 ]
Check return value after bulk lookup.
Coverity issue: 357746
Fixes: 14b8ab576235 ("hash: add bulk lookup with signatures array")
Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
app/test/test_hash_perf.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c
index 76cdac5d53..199564bba3 100644
--- a/app/test/test_hash_perf.c
+++ b/app/test/test_hash_perf.c
@@ -480,6 +480,11 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data,
(const void **)keys_burst,
&signatures[j * BURST_SIZE],
BURST_SIZE, positions_burst);
+ if (ret != 0) {
+ printf("rte_hash_lookup_with_hash_bulk failed with %d\n",
+ ret);
+ return -1;
+ }
for (k = 0; k < BURST_SIZE; k++) {
if (positions_burst[k] !=
positions[j *
@@ -492,10 +497,14 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data,
}
}
} else {
- rte_hash_lookup_bulk(h[table_index],
+ ret = rte_hash_lookup_bulk(h[table_index],
(const void **) keys_burst,
BURST_SIZE,
positions_burst);
+ if (ret != 0) {
+ printf("rte_hash_lookup_bulk failed with %d\n", ret);
+ return -1;
+ }
for (k = 0; k < BURST_SIZE; k++) {
if (positions_burst[k] != positions[j * BURST_SIZE + k]) {
printf("Key looked up in %d, should be in %d\n",
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2022-11-17 23:07:55.972196221 +0000
+++ 0011-test-hash-fix-bulk-lookup-check.patch 2022-11-17 23:07:55.448329376 +0000
@@ -1 +1 @@
-From 521171cf2a3cbc108ec920874cfa3706e7f89c73 Mon Sep 17 00:00:00 2001
+From 0053fb1fe8feb7be4f06f5097095f2cb4967938e Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 521171cf2a3cbc108ec920874cfa3706e7f89c73 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 5d36c0f454..14a1283aba 100644
+index 76cdac5d53..199564bba3 100644
@@ -22 +23 @@
-@@ -475,6 +475,11 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data,
+@@ -480,6 +480,11 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data,
@@ -34 +35 @@
-@@ -487,10 +492,14 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data,
+@@ -492,10 +497,14 @@ timed_lookups_multi(unsigned int with_hash, unsigned int with_data,
More information about the stable
mailing list