patch 'baseband/acc: fix check after deref and dead code' has been queued to stable release 22.11.2
Xueming Li
xuemingl at nvidia.com
Sun Apr 9 17:23:20 CEST 2023
Hi,
FYI, your patch has been queued to stable release 22.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/11/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/4bdaf5003136cbd9105fc53062924f2a2d72ab81
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 4bdaf5003136cbd9105fc53062924f2a2d72ab81 Mon Sep 17 00:00:00 2001
From: Hernan Vargas <hernan.vargas at intel.com>
Date: Wed, 22 Feb 2023 08:40:41 -0800
Subject: [PATCH] baseband/acc: fix check after deref and dead code
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 01eac6204617cdc60b67934a627dbf0b9b2d5e0f ]
Fix potential issue of dereferencing a pointer before null check.
Remove null check for value that could never be null.
Coverity issue: 381646, 381631
Fixes: 989dec301a98 ("baseband/acc100: add ring companion address")
Signed-off-by: Hernan Vargas <hernan.vargas at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
drivers/baseband/acc/rte_acc100_pmd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
index 1ca95f4440..7757db81fe 100644
--- a/drivers/baseband/acc/rte_acc100_pmd.c
+++ b/drivers/baseband/acc/rte_acc100_pmd.c
@@ -4124,8 +4124,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,
struct rte_bbdev_enc_op *op;
union acc_dma_desc *desc;
- if (q == NULL)
- return 0;
#ifdef RTE_LIBRTE_BBDEV_DEBUG
if (unlikely(ops == 0))
return 0;
--
2.25.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-04-09 21:45:39.149745400 +0800
+++ 0012-baseband-acc-fix-check-after-deref-and-dead-code.patch 2023-04-09 21:45:38.589042200 +0800
@@ -1 +1 @@
-From 01eac6204617cdc60b67934a627dbf0b9b2d5e0f Mon Sep 17 00:00:00 2001
+From 4bdaf5003136cbd9105fc53062924f2a2d72ab81 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 01eac6204617cdc60b67934a627dbf0b9b2d5e0f ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index 40b5eaf089..e485381a3f 100644
+index 1ca95f4440..7757db81fe 100644
@@ -23,2 +25 @@
-@@ -4106,8 +4106,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,
- int ret, cbm;
+@@ -4124,8 +4124,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,
@@ -25,0 +27 @@
+ union acc_dma_desc *desc;
More information about the stable
mailing list