patch 'ethdev: remove telemetry Rx mbuf alloc failed field' has been queued to stable release 22.11.2

Xueming Li xuemingl at nvidia.com
Sun Apr 9 17:23:46 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/11/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/aaa501436cdea8d1b5106a4308895ef216a187a9

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From aaa501436cdea8d1b5106a4308895ef216a187a9 Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at amd.com>
Date: Tue, 28 Feb 2023 18:02:30 +0000
Subject: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 6686b2d2a0b68698d7bddf51d5a9861fb8a4eaf3 ]

'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
which is exposed via ehtdev stat APIs.

But telemetry exposes this field to user via "/ethdev/info",
instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".

Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs

Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")

Signed-off-by: Ferruh Yigit <ferruh.yigit at amd.com>
Acked-by: Thomas Monjalon <thomas at monjalon.net>
Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
---
 lib/ethdev/rte_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index a40d396677..b9c8f79f8c 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -6039,8 +6039,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
 	rte_tel_data_add_dict_int(d, "mtu", eth_dev->data->mtu);
 	rte_tel_data_add_dict_u64(d, "rx_mbuf_size_min",
 			eth_dev->data->min_rx_buf_size);
-	rte_tel_data_add_dict_u64(d, "rx_mbuf_alloc_fail",
-			eth_dev->data->rx_mbuf_alloc_failed);
 	rte_ether_format_addr(mac_addr, sizeof(mac_addr),
 			eth_dev->data->mac_addrs);
 	rte_tel_data_add_dict_string(d, "mac_addr", mac_addr);
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-04-09 21:45:39.767644700 +0800
+++ 0038-ethdev-remove-telemetry-Rx-mbuf-alloc-failed-field.patch	2023-04-09 21:45:38.619042200 +0800
@@ -1 +1 @@
-From 6686b2d2a0b68698d7bddf51d5a9861fb8a4eaf3 Mon Sep 17 00:00:00 2001
+From aaa501436cdea8d1b5106a4308895ef216a187a9 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 6686b2d2a0b68698d7bddf51d5a9861fb8a4eaf3 ]
@@ -16 +18,0 @@
-Cc: stable at dpdk.org
@@ -26 +28 @@
-index 3814c202cd..3d137523a6 100644
+index a40d396677..b9c8f79f8c 100644
@@ -29 +31 @@
-@@ -6642,8 +6642,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
+@@ -6039,8 +6039,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
@@ -31 +33 @@
- 	rte_tel_data_add_dict_uint(d, "rx_mbuf_size_min",
+ 	rte_tel_data_add_dict_u64(d, "rx_mbuf_size_min",
@@ -33 +35 @@
--	rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
+-	rte_tel_data_add_dict_u64(d, "rx_mbuf_alloc_fail",


More information about the stable mailing list