patch 'net/ngbe: adapt to MNG veto bit setting' has been queued to stable release 22.11.3

Xueming Li xuemingl at nvidia.com
Thu Aug 10 01:47:50 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/11/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=1c7e19d4a04133db8edbc21a90cef48c45fe0767

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 1c7e19d4a04133db8edbc21a90cef48c45fe0767 Mon Sep 17 00:00:00 2001
From: Jiawen Wu <jiawenwu at trustnetic.com>
Date: Wed, 14 Jun 2023 10:34:27 +0800
Subject: [PATCH] net/ngbe: adapt to MNG veto bit setting
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 6f05dc6caf5c0e32ba7620c29ca5a176b36736f8 ]

In the new firmware, MNG veto bit is set by default for new features.
It causes the PHY configuration not to be reset after LAN reset. So PHY
power will be down after stopping device. The internal PHY then cannot
be initialized successfully at device start.

Add setting power on for internal PHY to fix this issue.

Fixes: abea8974c7a6 ("net/ngbe: support link down/up")

Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>
---
 drivers/net/ngbe/base/ngbe_phy_rtl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ngbe/base/ngbe_phy_rtl.c b/drivers/net/ngbe/base/ngbe_phy_rtl.c
index 9b323624ec..88bacec114 100644
--- a/drivers/net/ngbe/base/ngbe_phy_rtl.c
+++ b/drivers/net/ngbe/base/ngbe_phy_rtl.c
@@ -120,6 +120,8 @@ s32 ngbe_init_phy_rtl(struct ngbe_hw *hw)
 	hw->init_phy = true;
 	msec_delay(1);
 
+	hw->phy.set_phy_power(hw, true);
+
 	for (i = 0; i < 15; i++) {
 		if (!rd32m(hw, NGBE_STAT,
 			NGBE_STAT_GPHY_IN_RST(hw->bus.lan_id)))
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-08-09 21:51:18.994660900 +0800
+++ 0028-net-ngbe-adapt-to-MNG-veto-bit-setting.patch	2023-08-09 21:51:18.154352000 +0800
@@ -1 +1 @@
-From 6f05dc6caf5c0e32ba7620c29ca5a176b36736f8 Mon Sep 17 00:00:00 2001
+From 1c7e19d4a04133db8edbc21a90cef48c45fe0767 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 6f05dc6caf5c0e32ba7620c29ca5a176b36736f8 ]
@@ -14 +16,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list