patch 'net/netvsc: fix sizeof calculation' has been queued to stable release 22.11.3
Xueming Li
xuemingl at nvidia.com
Thu Aug 10 01:58:38 CEST 2023
Hi,
FYI, your patch has been queued to stable release 22.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/11/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=67912c46f49c1b2617aac34e9c4e4fc05fbf7c3d
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 67912c46f49c1b2617aac34e9c4e4fc05fbf7c3d Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Wed, 28 Jun 2023 17:29:57 -0700
Subject: [PATCH] net/netvsc: fix sizeof calculation
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 86fb73f5bf401afc9d52144f27e6d1cf4f64348b ]
Found by cppcheck.
drivers/net/netvsc/hn_rndis.c:332:21: warning:
Found calculation inside sizeof().
[sizeofCalculation] if (len < sizeof(3 * sizeof(uint32_t))) {
Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Signed-off-by: Long Li <longli at microsoft.com>
---
drivers/net/netvsc/hn_rndis.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/netvsc/hn_rndis.c b/drivers/net/netvsc/hn_rndis.c
index e6f1f28768..29c6009b2c 100644
--- a/drivers/net/netvsc/hn_rndis.c
+++ b/drivers/net/netvsc/hn_rndis.c
@@ -329,7 +329,8 @@ void hn_rndis_receive_response(struct hn_data *hv,
hn_rndis_dump(data);
- if (len < sizeof(3 * sizeof(uint32_t))) {
+ /* Check we can read first three data fields from RNDIS header */
+ if (len < 3 * sizeof(uint32_t)) {
PMD_DRV_LOG(ERR,
"missing RNDIS header %u", len);
return;
--
2.25.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-08-09 21:51:19.697626300 +0800
+++ 0059-net-netvsc-fix-sizeof-calculation.patch 2023-08-09 21:51:18.204352000 +0800
@@ -1 +1 @@
-From 86fb73f5bf401afc9d52144f27e6d1cf4f64348b Mon Sep 17 00:00:00 2001
+From 67912c46f49c1b2617aac34e9c4e4fc05fbf7c3d Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 86fb73f5bf401afc9d52144f27e6d1cf4f64348b ]
@@ -13 +15,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list