patch 'net/mana: fix counter overflow for posted WQE' has been queued to stable release 22.11.3
Xueming Li
xuemingl at nvidia.com
Thu Aug 10 01:58:48 CEST 2023
Hi,
FYI, your patch has been queued to stable release 22.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/11/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=0a2bee7f05a49852d046c8bb89e28728da22f0bd
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 0a2bee7f05a49852d046c8bb89e28728da22f0bd Mon Sep 17 00:00:00 2001
From: Long Li <longli at microsoft.com>
Date: Mon, 10 Jul 2023 16:51:07 -0700
Subject: [PATCH] net/mana: fix counter overflow for posted WQE
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 8a56ff3d246899b77b81c6450680214a8697749b ]
This counter should set to uint16_t, the same type as pkt_received.
Otherwise, it may overflow when pkt_received goes over 256.
Thanks Xinhao Kong <t-kongxinhao at microsoft.com> for debugging this.
Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
Signed-off-by: Long Li <longli at microsoft.com>
---
drivers/net/mana/rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mana/rx.c b/drivers/net/mana/rx.c
index 6e1c397be8..5c5f609ece 100644
--- a/drivers/net/mana/rx.c
+++ b/drivers/net/mana/rx.c
@@ -380,7 +380,7 @@ uint16_t
mana_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)
{
uint16_t pkt_received = 0;
- uint8_t wqe_posted = 0;
+ uint16_t wqe_posted = 0;
struct mana_rxq *rxq = dpdk_rxq;
struct mana_priv *priv = rxq->priv;
struct rte_mbuf *mbuf;
--
2.25.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-08-09 21:51:19.941468600 +0800
+++ 0069-net-mana-fix-counter-overflow-for-posted-WQE.patch 2023-08-09 21:51:18.214352000 +0800
@@ -1 +1 @@
-From 8a56ff3d246899b77b81c6450680214a8697749b Mon Sep 17 00:00:00 2001
+From 0a2bee7f05a49852d046c8bb89e28728da22f0bd Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 8a56ff3d246899b77b81c6450680214a8697749b ]
@@ -12 +14,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index 220b372b15..6ba0a712ef 100644
+index 6e1c397be8..5c5f609ece 100644
@@ -23 +25 @@
-@@ -384,7 +384,7 @@ uint16_t
+@@ -380,7 +380,7 @@ uint16_t
More information about the stable
mailing list