patch 'devtools: fix bashism in mailmap check' has been queued to stable release 22.11.3

Xueming Li xuemingl at nvidia.com
Thu Aug 10 02:10:21 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/11/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=e3f30fa9c8c59532071252954c7f00567ec17e58

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From e3f30fa9c8c59532071252954c7f00567ec17e58 Mon Sep 17 00:00:00 2001
From: Raslan Darawsheh <rasland at nvidia.com>
Date: Tue, 11 Jul 2023 10:16:19 +0300
Subject: [PATCH] devtools: fix bashism in mailmap check
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 8aec1d8f498e7f87ee65a4b31df9a205084cb39e ]

When running check-git-log, it showed a "Bad substitution",
because of a bash syntax.

It is fixed by using sed to escape the open parenthesis.

Fixes: 6fd14c1b58e6 ("devtools: fix mailmap check for parentheses")

Signed-off-by: Raslan Darawsheh <rasland at nvidia.com>
Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
---
 devtools/check-git-log.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
index 89544a2cc5..2ee7f2db64 100755
--- a/devtools/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -264,7 +264,7 @@ names=$(git log --format='From: %an <%ae>%n%b' --reverse $range |
 	sed -rn 's,.*: (.*<.*@.*>),\1,p' |
 	sort -u)
 bad=$(for contributor in $names ; do
-	contributor=${contributor//(/\\(}
+	contributor=$(echo $contributor | sed 's,(,\\(,')
 	! grep -qE "^$contributor($| <)" $selfdir/../.mailmap || continue
 	name=${contributor%% <*}
 	if grep -q "^$name <" $selfdir/../.mailmap ; then
--
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-08-09 21:51:20.837240600 +0800
+++ 0104-devtools-fix-bashism-in-mailmap-check.patch	2023-08-09 21:51:18.274352000 +0800
@@ -1 +1 @@
-From 8aec1d8f498e7f87ee65a4b31df9a205084cb39e Mon Sep 17 00:00:00 2001
+From e3f30fa9c8c59532071252954c7f00567ec17e58 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 8aec1d8f498e7f87ee65a4b31df9a205084cb39e ]
@@ -12 +14,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list