[PATCH v1] net/memif: fix segfault with Tx burst larger than 255

[Joyce Kong]

> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Wednesday, December 6, 2023 2:34 AM
> To: Joyce Kong <Joyce.Kong at arm.com>
> Cc: Jakub Grajciar <jgrajcia at cisco.com>; Morten Brørup
> <mb at smartsharesystems.com>; Ruifeng Wang <Ruifeng.Wang at arm.com>;
> dev at dpdk.org; nd <nd at arm.com>; stable at dpdk.org; Liangxing Wang
> <Liangxing.Wang at arm.com>
> Subject: Re: [PATCH v1] net/memif: fix segfault with Tx burst larger than 255
> 
> On Tue,  5 Dec 2023 04:05:24 +0000
> Joyce Kong <joyce.kong at arm.com> wrote:
> 
> > There will be a segfault when tx burst size is larger than 256. This
> > is because eth_memif_tx uses an index i which is uint8_t to count
> > transmitted nb_pkts. Extend i to uint16_t, the same size as nb_pkts.
> >
> > Fixes: b5613c8f9d0a ("net/memif: add a Tx fast path")
> > Cc: stable at dpdk.org
> >
> > Reported-by: Liangxing Wang <liangxing.wang at arm.com>
> > Signed-off-by: Joyce Kong <joyce.kong at arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
> > ---
> 
> I wonder if other drivers have same bug?

I don't think this is a common bug.
This is a special case as the bug is introduced for whether choosing the memif Tx fast path. 

> 
> Reviewed-by: Stephen Hemminger <stephen at networkplumber.org>