patch 'mempool: fix get function documentation' has been queued to stable release 22.11.4
Xueming Li
xuemingl at nvidia.com
Mon Dec 11 11:12:20 CET 2023
Hi,
FYI, your patch has been queued to stable release 22.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/13/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=9c68d8a8459bfa3103ba257ae811babda9fb323c
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 9c68d8a8459bfa3103ba257ae811babda9fb323c Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at amd.com>
Date: Mon, 23 Oct 2023 10:38:42 +0100
Subject: [PATCH] mempool: fix get function documentation
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 9b3233ab09ea331dcf5fb38d215d91818bef3b47 ]
static function `rte_mempool_do_generic_get()` returns zero on success,
not >=0 as its function comment documents.
Since this function called by public API, the comment causes confusion
on the public API return value.
Fixing the internal function documentation for return value.
Fixes: af75078fece3 ("first public release")
Reported-by: Mahesh Adulla <mahesh.adulla at amd.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit at amd.com>
Reviewed-by: Morten Brørup <mb at smartsharesystems.com>
Acked-by: Huisong Li <lihuisong at huawei.com>
---
.mailmap | 1 +
lib/mempool/rte_mempool.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/.mailmap b/.mailmap
index 9b523c9959..a97dce5fcf 100644
--- a/.mailmap
+++ b/.mailmap
@@ -806,6 +806,7 @@ Maciej Paczkowski <maciej.paczkowski at intel.com>
Maciej Rabeda <maciej.rabeda at intel.com>
Maciej Szwed <maciej.szwed at intel.com>
Madhuker Mythri <madhuker.mythri at oracle.com>
+Mahesh Adulla <mahesh.adulla at amd.com>
Mahipal Challa <mchalla at marvell.com>
Mah Yock Gen <yock.gen.mah at intel.com>
Mairtin o Loingsigh <mairtin.oloingsigh at intel.com>
diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h
index 9f530db24b..f1eb2cd2d3 100644
--- a/lib/mempool/rte_mempool.h
+++ b/lib/mempool/rte_mempool.h
@@ -1484,7 +1484,7 @@ rte_mempool_put(struct rte_mempool *mp, void *obj)
* @param cache
* A pointer to a mempool cache structure. May be NULL if not needed.
* @return
- * - >=0: Success; number of objects supplied.
+ * - 0: Success.
* - <0: Error; code of driver dequeue function.
*/
static __rte_always_inline int
--
2.25.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-12-11 17:56:26.770569300 +0800
+++ 0115-mempool-fix-get-function-documentation.patch 2023-12-11 17:56:23.237652300 +0800
@@ -1 +1 @@
-From 9b3233ab09ea331dcf5fb38d215d91818bef3b47 Mon Sep 17 00:00:00 2001
+From 9c68d8a8459bfa3103ba257ae811babda9fb323c Mon Sep 17 00:00:00 2001
@@ -7,0 +8,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 9b3233ab09ea331dcf5fb38d215d91818bef3b47 ]
@@ -18 +20,0 @@
-Cc: stable at dpdk.org
@@ -30 +32 @@
-index 49d3616c4c..3630e72f41 100644
+index 9b523c9959..a97dce5fcf 100644
@@ -33 +35,2 @@
-@@ -839,6 +839,7 @@ Maciej Rabeda <maciej.rabeda at intel.com>
+@@ -806,6 +806,7 @@ Maciej Paczkowski <maciej.paczkowski at intel.com>
+ Maciej Rabeda <maciej.rabeda at intel.com>
@@ -35 +37,0 @@
- Madhu Chittim <madhu.chittim at intel.com>
@@ -42 +44 @@
-index df87cd231e..1303eef494 100644
+index 9f530db24b..f1eb2cd2d3 100644
More information about the stable
mailing list