patch 'net/hns3: refactor set RSS hash algorithm and key interface' has been queued to stable release 20.11.8
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Feb 23 10:36:44 CET 2023
Hi,
FYI, your patch has been queued to stable release 20.11.8
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/25/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/43aad169fa3c11e4a6d1a1d2a29ddee459846d72
Thanks.
Luca Boccassi
---
>From 43aad169fa3c11e4a6d1a1d2a29ddee459846d72 Mon Sep 17 00:00:00 2001
From: Huisong Li <lihuisong at huawei.com>
Date: Tue, 31 Jan 2023 21:02:53 +0800
Subject: [PATCH] net/hns3: refactor set RSS hash algorithm and key interface
[ upstream commit 88347111eb53bc54c598dde81715a06ca1dbd132 ]
The hns3_rss_set_algo_key() is used to set RSS hash algorithm and key to
hardware.
The maximum execution time of the command sent to the firmware is
proportional to the length of the key.
However, now this times is fixed, which isn't good for key expansion.
In addition, hash algorithm comes from rss_info::hash_algo maintained in
the driver, which also isn't good for the usage of this function.
Interface is updated to get hash algorithm and key length as input
parameters.
Fixes: c37ca66f2b27 ("net/hns3: support RSS")
Signed-off-by: Huisong Li <lihuisong at huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3 at huawei.com>
---
drivers/net/hns3/hns3_flow.c | 3 ++-
drivers/net/hns3/hns3_rss.c | 48 ++++++++++++++++--------------------
drivers/net/hns3/hns3_rss.h | 4 ++-
3 files changed, 26 insertions(+), 29 deletions(-)
diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c
index facd4c5be7..fedc3ee664 100644
--- a/drivers/net/hns3/hns3_flow.c
+++ b/drivers/net/hns3/hns3_flow.c
@@ -1462,7 +1462,8 @@ hns3_hw_rss_hash_set(struct hns3_hw *hw, struct rte_flow_action_rss *rss_config)
if (ret)
return ret;
- ret = hns3_set_rss_algo_key(hw, rss_config->key);
+ ret = hns3_set_rss_algo_key(hw, hw->rss_info.hash_algo,
+ rss_config->key, HNS3_RSS_KEY_SIZE);
if (ret)
return ret;
diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c
index c105072f24..e1bf8f36f1 100644
--- a/drivers/net/hns3/hns3_rss.c
+++ b/drivers/net/hns3/hns3_rss.c
@@ -277,45 +277,37 @@ static const struct {
/*
* rss_generic_config command function, opcode:0x0D01.
- * Used to set algorithm, key_offset and hash key of rss.
+ * Used to set algorithm and hash key of RSS.
*/
int
-hns3_set_rss_algo_key(struct hns3_hw *hw, const uint8_t *key)
+hns3_set_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo,
+ const uint8_t *key, uint8_t key_len)
{
-#define HNS3_KEY_OFFSET_MAX 3
-#define HNS3_SET_HASH_KEY_BYTE_FOUR 2
-
struct hns3_rss_generic_config_cmd *req;
struct hns3_cmd_desc desc;
- uint32_t key_offset, key_size;
- const uint8_t *key_cur;
- uint8_t cur_offset;
+ const uint8_t *cur_key;
+ uint16_t cur_key_size;
+ uint16_t max_bd_num;
+ uint16_t idx;
int ret;
req = (struct hns3_rss_generic_config_cmd *)desc.data;
- /*
- * key_offset=0, hash key byte0~15 is set to hardware.
- * key_offset=1, hash key byte16~31 is set to hardware.
- * key_offset=2, hash key byte32~39 is set to hardware.
- */
- for (key_offset = 0; key_offset < HNS3_KEY_OFFSET_MAX; key_offset++) {
+ max_bd_num = DIV_ROUND_UP(key_len, HNS3_RSS_HASH_KEY_NUM);
+ for (idx = 0; idx < max_bd_num; idx++) {
hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_RSS_GENERIC_CONFIG,
false);
- req->hash_config |=
- (hw->rss_info.hash_algo & HNS3_RSS_HASH_ALGO_MASK);
- req->hash_config |= (key_offset << HNS3_RSS_HASH_KEY_OFFSET_B);
+ req->hash_config |= (hash_algo & HNS3_RSS_HASH_ALGO_MASK);
+ req->hash_config |= (idx << HNS3_RSS_HASH_KEY_OFFSET_B);
- if (key_offset == HNS3_SET_HASH_KEY_BYTE_FOUR)
- key_size = HNS3_RSS_KEY_SIZE - HNS3_RSS_HASH_KEY_NUM *
- HNS3_SET_HASH_KEY_BYTE_FOUR;
+ if (idx == max_bd_num - 1)
+ cur_key_size = key_len % HNS3_RSS_HASH_KEY_NUM;
else
- key_size = HNS3_RSS_HASH_KEY_NUM;
+ cur_key_size = HNS3_RSS_HASH_KEY_NUM;
- cur_offset = key_offset * HNS3_RSS_HASH_KEY_NUM;
- key_cur = key + cur_offset;
- memcpy(req->hash_key, key_cur, key_size);
+ cur_key = key + idx * HNS3_RSS_HASH_KEY_NUM;
+ memcpy(req->hash_key, cur_key, cur_key_size);
ret = hns3_cmd_send(hw, &desc, 1);
if (ret) {
@@ -518,7 +510,8 @@ hns3_dev_rss_hash_update(struct rte_eth_dev *dev,
goto set_tuple_fail;
if (key) {
- ret = hns3_set_rss_algo_key(hw, key);
+ ret = hns3_set_rss_algo_key(hw, hw->rss_info.hash_algo,
+ key, HNS3_RSS_KEY_SIZE);
if (ret)
goto set_algo_key_fail;
}
@@ -800,8 +793,9 @@ hns3_config_rss(struct hns3_adapter *hns)
break;
}
- /* Configure RSS hash algorithm and hash key offset */
- ret = hns3_set_rss_algo_key(hw, hash_key);
+ /* Configure RSS hash algorithm and hash key */
+ ret = hns3_set_rss_algo_key(hw, hw->rss_info.hash_algo, hash_key,
+ HNS3_RSS_KEY_SIZE);
if (ret)
return ret;
diff --git a/drivers/net/hns3/hns3_rss.h b/drivers/net/hns3/hns3_rss.h
index 751e3475ed..630229796c 100644
--- a/drivers/net/hns3/hns3_rss.h
+++ b/drivers/net/hns3/hns3_rss.h
@@ -113,7 +113,9 @@ int hns3_rss_reset_indir_table(struct hns3_hw *hw);
int hns3_config_rss(struct hns3_adapter *hns);
void hns3_rss_uninit(struct hns3_adapter *hns);
int hns3_set_rss_tuple_by_rss_hf(struct hns3_hw *hw, uint64_t rss_hf);
-int hns3_set_rss_algo_key(struct hns3_hw *hw, const uint8_t *key);
+int hns3_set_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo,
+ const uint8_t *key, uint8_t key_len);
int hns3_restore_filter(struct hns3_adapter *hns);
+
#endif /* _HNS3_RSS_H_ */
--
2.39.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-02-23 09:36:29.842596160 +0000
+++ 0040-net-hns3-refactor-set-RSS-hash-algorithm-and-key-int.patch 2023-02-23 09:36:28.262170603 +0000
@@ -1 +1 @@
-From 88347111eb53bc54c598dde81715a06ca1dbd132 Mon Sep 17 00:00:00 2001
+From 43aad169fa3c11e4a6d1a1d2a29ddee459846d72 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 88347111eb53bc54c598dde81715a06ca1dbd132 ]
+
@@ -19 +20,0 @@
-Cc: stable at dpdk.org
@@ -30 +31 @@
-index e88f9b7e45..ac094c839f 100644
+index facd4c5be7..fedc3ee664 100644
@@ -33 +34 @@
-@@ -1494,7 +1494,8 @@ hns3_hw_rss_hash_set(struct hns3_hw *hw, struct rte_flow_action_rss *rss_config)
+@@ -1462,7 +1462,8 @@ hns3_hw_rss_hash_set(struct hns3_hw *hw, struct rte_flow_action_rss *rss_config)
@@ -37,2 +38,2 @@
-- ret = hns3_rss_set_algo_key(hw, rss_config->key);
-+ ret = hns3_rss_set_algo_key(hw, hw->rss_info.hash_algo,
+- ret = hns3_set_rss_algo_key(hw, rss_config->key);
++ ret = hns3_set_rss_algo_key(hw, hw->rss_info.hash_algo,
@@ -44 +45 @@
-index ca5a129234..3db7bf0445 100644
+index c105072f24..e1bf8f36f1 100644
@@ -55,2 +56,2 @@
--hns3_rss_set_algo_key(struct hns3_hw *hw, const uint8_t *key)
-+hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo,
+-hns3_set_rss_algo_key(struct hns3_hw *hw, const uint8_t *key)
++hns3_set_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo,
@@ -113,2 +114,2 @@
-- ret = hns3_rss_set_algo_key(hw, key);
-+ ret = hns3_rss_set_algo_key(hw, hw->rss_info.hash_algo,
+- ret = hns3_set_rss_algo_key(hw, key);
++ ret = hns3_set_rss_algo_key(hw, hw->rss_info.hash_algo,
@@ -119 +120 @@
-@@ -795,8 +788,9 @@ hns3_config_rss(struct hns3_adapter *hns)
+@@ -800,8 +793,9 @@ hns3_config_rss(struct hns3_adapter *hns)
@@ -124 +125 @@
-- ret = hns3_rss_set_algo_key(hw, hash_key);
+- ret = hns3_set_rss_algo_key(hw, hash_key);
@@ -126 +127 @@
-+ ret = hns3_rss_set_algo_key(hw, hw->rss_info.hash_algo, hash_key,
++ ret = hns3_set_rss_algo_key(hw, hw->rss_info.hash_algo, hash_key,
@@ -132 +133 @@
-index 8e8b056f4e..b7f62ca1ee 100644
+index 751e3475ed..630229796c 100644
@@ -135 +136 @@
-@@ -109,6 +109,8 @@ int hns3_rss_reset_indir_table(struct hns3_hw *hw);
+@@ -113,7 +113,9 @@ int hns3_rss_reset_indir_table(struct hns3_hw *hw);
@@ -139,2 +140,2 @@
--int hns3_rss_set_algo_key(struct hns3_hw *hw, const uint8_t *key);
-+int hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo,
+-int hns3_set_rss_algo_key(struct hns3_hw *hw, const uint8_t *key);
++int hns3_set_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo,
@@ -142 +143 @@
-+
+ int hns3_restore_filter(struct hns3_adapter *hns);
@@ -144 +145,2 @@
- #endif /* HNS3_RSS_H */
++
+ #endif /* _HNS3_RSS_H_ */
More information about the stable
mailing list