patch 'net/bnxt: fix link state change interrupt config' has been queued to stable release 20.11.8
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Feb 23 10:37:07 CET 2023
Hi,
FYI, your patch has been queued to stable release 20.11.8
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/25/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/de481ff9ddb85bddac2834cbdae53280a119aa3d
Thanks.
Luca Boccassi
---
>From de481ff9ddb85bddac2834cbdae53280a119aa3d Mon Sep 17 00:00:00 2001
From: Edwin Brossette <edwin.brossette at 6wind.com>
Date: Mon, 6 Feb 2023 18:11:13 +0100
Subject: [PATCH] net/bnxt: fix link state change interrupt config
[ upstream commit 60653f4a25bd87a32bc148461f32566af997da8b ]
When getting the device's info via bnxt_dev_info_get_op(), the device
enables interrupts on link state changes because of the following line:
eth_dev->data->dev_conf.intr_conf.lsc = 1;
Enabling this mode might not be wanted by the user.
The flag RTE_ETH_DEV_INTR_LSC can be used to inform the above
application that LSC interrupts are supported. Thus, checking this flag,
the user can decide whether or not to enable these interrupts.
Since there is no reason for a function meant to display config to
actually modify it, remove this line. In addition, raise the dev_flag
associated with this state on the device's initialization to show the
device supports link state change interrupts.
Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification")
Signed-off-by: Edwin Brossette <edwin.brossette at 6wind.com>
Acked-by: Somnath Kotur <somnath.kotur at broadcom.com>
Acked-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 44056c9c4d..827253ff1c 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1030,7 +1030,6 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
.tx_free_thresh = 32,
.tx_rs_thresh = 32,
};
- eth_dev->data->dev_conf.intr_conf.lsc = 1;
dev_info->rx_desc_lim.nb_min = BNXT_MIN_RING_DESC;
dev_info->rx_desc_lim.nb_max = BNXT_MAX_RX_RING_DESC;
@@ -5772,6 +5771,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)
rte_eth_copy_pci_info(eth_dev, pci_dev);
eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
+ eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;
bp = eth_dev->data->dev_private;
--
2.39.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-02-23 09:36:30.763745888 +0000
+++ 0063-net-bnxt-fix-link-state-change-interrupt-config.patch 2023-02-23 09:36:28.346172150 +0000
@@ -1 +1 @@
-From 60653f4a25bd87a32bc148461f32566af997da8b Mon Sep 17 00:00:00 2001
+From de481ff9ddb85bddac2834cbdae53280a119aa3d Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 60653f4a25bd87a32bc148461f32566af997da8b ]
+
@@ -23 +24,0 @@
-Cc: stable at dpdk.org
@@ -29 +29,0 @@
- .mailmap | 1 +
@@ -31 +31 @@
- 2 files changed, 2 insertions(+), 1 deletion(-)
+ 1 file changed, 1 insertion(+), 1 deletion(-)
@@ -33,12 +32,0 @@
-diff --git a/.mailmap b/.mailmap
-index e111e05bc2..a9f4f28fba 100644
---- a/.mailmap
-+++ b/.mailmap
-@@ -339,6 +339,7 @@ Dzmitry Sautsa <dzmitryx.sautsa at intel.com>
- Ed Czeck <ed.czeck at atomicrules.com>
- Eduard Serra <eserra at vmware.com>
- Edward Makarov <makarov at kraftway.ru>
-+Edwin Brossette <edwin.brossette at 6wind.com>
- Eelco Chaudron <echaudro at redhat.com>
- Elad Nachman <eladv6 at gmail.com>
- Elad Persiko <eladpe at mellanox.com>
@@ -46 +34 @@
-index b3de490d36..753e86b4b2 100644
+index 44056c9c4d..827253ff1c 100644
@@ -49 +37 @@
-@@ -1017,7 +1017,6 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
+@@ -1030,7 +1030,6 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
@@ -57 +45 @@
-@@ -5859,6 +5858,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)
+@@ -5772,6 +5771,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)
More information about the stable
mailing list