patch 'baseband/acc: fix memory leak on acc100 close' has been queued to stable release 21.11.4
Kevin Traynor
ktraynor at redhat.com
Thu Feb 23 16:05:17 CET 2023
Hi,
FYI, your patch has been queued to stable release 21.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/28/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/3664b67985f2bdab3ec33c0b5f38b6f023d8c987
Thanks.
Kevin
---
>From 3664b67985f2bdab3ec33c0b5f38b6f023d8c987 Mon Sep 17 00:00:00 2001
From: Hernan Vargas <hernan.vargas at intel.com>
Date: Thu, 12 Jan 2023 11:36:03 -0800
Subject: [PATCH] baseband/acc: fix memory leak on acc100 close
[ upstream commit 1bc7f26ebd45da2ab2740a00c991100dc8f0037d ]
Explicitly call rte_free for harq_layout pointer in dev_close function
to prevent memory leak.
Fixes: ba2262fe16c ("baseband/acc100: fix close cleanup")
Signed-off-by: Hernan Vargas <hernan.vargas at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
drivers/baseband/acc100/rte_acc100_pmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
index eba6eb0df4..713e58fb54 100644
--- a/drivers/baseband/acc100/rte_acc100_pmd.c
+++ b/drivers/baseband/acc100/rte_acc100_pmd.c
@@ -780,4 +780,5 @@ acc100_dev_close(struct rte_bbdev *dev)
rte_free(d->info_ring);
rte_free(d->sw_rings_base);
+ rte_free(d->harq_layout);
d->sw_rings_base = NULL;
d->tail_ptrs = NULL;
--
2.39.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-02-23 14:46:24.468853903 +0000
+++ 0026-baseband-acc-fix-memory-leak-on-acc100-close.patch 2023-02-23 14:46:23.736235847 +0000
@@ -1 +1 @@
-From 1bc7f26ebd45da2ab2740a00c991100dc8f0037d Mon Sep 17 00:00:00 2001
+From 3664b67985f2bdab3ec33c0b5f38b6f023d8c987 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 1bc7f26ebd45da2ab2740a00c991100dc8f0037d ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -15 +16 @@
- drivers/baseband/acc/rte_acc100_pmd.c | 1 +
+ drivers/baseband/acc100/rte_acc100_pmd.c | 1 +
@@ -18,5 +19,5 @@
-diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
-index b3164529dd..146a22bd64 100644
---- a/drivers/baseband/acc/rte_acc100_pmd.c
-+++ b/drivers/baseband/acc/rte_acc100_pmd.c
-@@ -621,4 +621,5 @@ acc100_dev_close(struct rte_bbdev *dev)
+diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
+index eba6eb0df4..713e58fb54 100644
+--- a/drivers/baseband/acc100/rte_acc100_pmd.c
++++ b/drivers/baseband/acc100/rte_acc100_pmd.c
+@@ -780,4 +780,5 @@ acc100_dev_close(struct rte_bbdev *dev)
More information about the stable
mailing list