patch 'net/bnxt: fix RSS hash in mbuf' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Thu Feb 23 16:05:27 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/28/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/2b15b1cd4a3994d5a09aa31990d7075d4caf9057

Thanks.

Kevin

---
>From 2b15b1cd4a3994d5a09aa31990d7075d4caf9057 Mon Sep 17 00:00:00 2001
From: Venkat Duvvuru <venkatkumar.duvvuru at broadcom.com>
Date: Wed, 1 Feb 2023 09:50:14 +0530
Subject: [PATCH] net/bnxt: fix RSS hash in mbuf

[ upstream commit 031102f531e87e25174d4744c4ced92e5b291891 ]

By clearing mbuf->hash.fdir.id in the data path, the driver is
corrupting the RSS hash value populated in the mbuf as they
are defined as a union.

This patch fixes the problem by removing the code that clears
mbuf->hash.fdir.id.

Fixes: 17b6c8386d73 ("net/bnxt: fix mark handling")

Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru at broadcom.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Reviewed-by: Kishore Padmanabha <kishore.padmanabha at broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_rxr.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index b60c2470f3..4e56c7c99f 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -814,5 +814,4 @@ bnxt_ulp_set_mark_in_mbuf(struct bnxt *bp, struct rx_pkt_cmpl_hi *rxcmp1,
 skip_mark:
 	mbuf->hash.fdir.hi = 0;
-	mbuf->hash.fdir.id = 0;
 
 	return 0;
-- 
2.39.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-23 14:46:24.704875077 +0000
+++ 0036-net-bnxt-fix-RSS-hash-in-mbuf.patch	2023-02-23 14:46:23.757235921 +0000
@@ -1 +1 @@
-From 031102f531e87e25174d4744c4ced92e5b291891 Mon Sep 17 00:00:00 2001
+From 2b15b1cd4a3994d5a09aa31990d7075d4caf9057 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 031102f531e87e25174d4744c4ced92e5b291891 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index daaf9ffc1e..0eebddb05d 100644
+index b60c2470f3..4e56c7c99f 100644



More information about the stable mailing list