patch 'net/txgbe: fix interrupt loss' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Thu Feb 23 16:05:46 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/28/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/489a1c2580f82b2e11878a659d3972c691a4b38f

Thanks.

Kevin

---
>From 489a1c2580f82b2e11878a659d3972c691a4b38f Mon Sep 17 00:00:00 2001
From: Jiawen Wu <jiawenwu at trustnetic.com>
Date: Thu, 2 Feb 2023 17:21:31 +0800
Subject: [PATCH] net/txgbe: fix interrupt loss

[ upstream commit a4315c1434b6bf78a9e04bf5fa34d02e9b3afd35 ]

Disable interrupt in the interrupt handling process will sometimes cause
interrupts to be lost.

Fixes: 2fc745e6b606 ("net/txgbe: add interrupt operation")

Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>
---
 drivers/net/txgbe/txgbe_ethdev.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index c229736d85..af2bf00ebd 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -2940,7 +2940,4 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev,
 		wr32(hw, TXGBE_PX_INTA, 1);
 
-	/* clear all cause mask */
-	txgbe_disable_intr(hw);
-
 	/* read-on-clear nic registers here */
 	eicr = ((u32 *)hw->isb_mem)[TXGBE_ISB_MISC];
@@ -2965,4 +2962,6 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev,
 		intr->flags |= TXGBE_FLAG_PHY_INTERRUPT;
 
+	((u32 *)hw->isb_mem)[TXGBE_ISB_MISC] = 0;
+
 	return 0;
 }
-- 
2.39.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-23 14:46:25.138666790 +0000
+++ 0055-net-txgbe-fix-interrupt-loss.patch	2023-02-23 14:46:23.790236036 +0000
@@ -1 +1 @@
-From a4315c1434b6bf78a9e04bf5fa34d02e9b3afd35 Mon Sep 17 00:00:00 2001
+From 489a1c2580f82b2e11878a659d3972c691a4b38f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a4315c1434b6bf78a9e04bf5fa34d02e9b3afd35 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index ce7cf2506d..6e939b8ce3 100644
+index c229736d85..af2bf00ebd 100644
@@ -21 +22 @@
-@@ -2973,7 +2973,4 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev,
+@@ -2940,7 +2940,4 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev,
@@ -29,2 +30,2 @@
-@@ -3001,4 +2998,6 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev,
- 		intr->flags |= TXGBE_FLAG_OVERHEAT;
+@@ -2965,4 +2962,6 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev,
+ 		intr->flags |= TXGBE_FLAG_PHY_INTERRUPT;



More information about the stable mailing list