patch 'net/iavf: protect insertion in flow list' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Thu Feb 23 16:06:12 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/28/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/a6aba6b291f31457ca378e0c7ca251b01ca9da9a

Thanks.

Kevin

---
>From a6aba6b291f31457ca378e0c7ca251b01ca9da9a Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Thu, 5 Jan 2023 14:57:43 +0100
Subject: [PATCH] net/iavf: protect insertion in flow list

[ upstream commit d79c3b264e31465695bc4c6279381522060a22f6 ]

Add missing lock acquire.

Fixes: ff2d0c345c3b ("net/iavf: support generic flow API")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Qi Zhang <qi.z.zhang at intel.com>
---
 drivers/net/iavf/iavf_generic_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_generic_flow.c b/drivers/net/iavf/iavf_generic_flow.c
index 2befa125ac..01e7b8724d 100644
--- a/drivers/net/iavf/iavf_generic_flow.c
+++ b/drivers/net/iavf/iavf_generic_flow.c
@@ -2221,9 +2221,10 @@ iavf_flow_create(struct rte_eth_dev *dev,
 
 	flow->engine = engine;
+	rte_spinlock_lock(&vf->flow_ops_lock);
 	TAILQ_INSERT_TAIL(&vf->flow_list, flow, node);
+	rte_spinlock_unlock(&vf->flow_ops_lock);
 	PMD_DRV_LOG(INFO, "Succeeded to create (%d) flow", engine->type);
 
 free_flow:
-	rte_spinlock_unlock(&vf->flow_ops_lock);
 	return flow;
 }
-- 
2.39.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-23 14:46:25.763037314 +0000
+++ 0081-net-iavf-protect-insertion-in-flow-list.patch	2023-02-23 14:46:23.864236293 +0000
@@ -1 +1 @@
-From d79c3b264e31465695bc4c6279381522060a22f6 Mon Sep 17 00:00:00 2001
+From a6aba6b291f31457ca378e0c7ca251b01ca9da9a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d79c3b264e31465695bc4c6279381522060a22f6 ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index f33c764764..6f6e95fc45 100644
+index 2befa125ac..01e7b8724d 100644
@@ -21 +22 @@
-@@ -2279,9 +2279,10 @@ iavf_flow_create(struct rte_eth_dev *dev,
+@@ -2221,9 +2221,10 @@ iavf_flow_create(struct rte_eth_dev *dev,



More information about the stable mailing list