patch 'examples/qos_sched: fix debug mode' has been queued to stable release 22.11.2
Xueming Li
xuemingl at nvidia.com
Mon Feb 27 07:59:05 CET 2023
Hi,
FYI, your patch has been queued to stable release 22.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/01/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=cb3c0ba47e45f4ae2dd395c3c3291cfb15a73970
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From cb3c0ba47e45f4ae2dd395c3c3291cfb15a73970 Mon Sep 17 00:00:00 2001
From: Megha Ajmera <megha.ajmera at intel.com>
Date: Thu, 5 Jan 2023 12:28:53 +0000
Subject: [PATCH] examples/qos_sched: fix debug mode
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit af13b8711aa43a851d2c12e5d3f8f87dd047307e ]
This issue is happening due to non-initialization of some
fields in “rte_eth_rxconf” structure in our application.
Doing a memset to zero before initialization in HQoS application.
Fixes: de3cfa2c9823 ("sched: initial import")
Signed-off-by: Megha Ajmera <megha.ajmera at intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
---
examples/qos_sched/init.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c
index 0709aec10c..d28350e14a 100644
--- a/examples/qos_sched/init.c
+++ b/examples/qos_sched/init.c
@@ -79,6 +79,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp)
if (app_inited_port_mask & (1u << portid))
return 0;
+ memset(&rx_conf, 0, sizeof(struct rte_eth_rxconf));
rx_conf.rx_thresh.pthresh = rx_thresh.pthresh;
rx_conf.rx_thresh.hthresh = rx_thresh.hthresh;
rx_conf.rx_thresh.wthresh = rx_thresh.wthresh;
@@ -86,6 +87,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp)
rx_conf.rx_drop_en = 0;
rx_conf.rx_deferred_start = 0;
+ memset(&tx_conf, 0, sizeof(struct rte_eth_txconf));
tx_conf.tx_thresh.pthresh = tx_thresh.pthresh;
tx_conf.tx_thresh.hthresh = tx_thresh.hthresh;
tx_conf.tx_thresh.wthresh = tx_thresh.wthresh;
--
2.25.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-02-27 14:08:42.131667400 +0800
+++ 0038-examples-qos_sched-fix-debug-mode.patch 2023-02-27 14:08:40.749237000 +0800
@@ -1 +1 @@
-From af13b8711aa43a851d2c12e5d3f8f87dd047307e Mon Sep 17 00:00:00 2001
+From cb3c0ba47e45f4ae2dd395c3c3291cfb15a73970 Mon Sep 17 00:00:00 2001
@@ -7,0 +8,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit af13b8711aa43a851d2c12e5d3f8f87dd047307e ]
@@ -14 +16,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list