patch 'vhost: decrease log level for unimplemented requests' has been queued to stable release 22.11.2

Xueming Li xuemingl at nvidia.com
Mon Feb 27 07:59:52 CET 2023


Hi,

FYI, your patch has been queued to stable release 22.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/01/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=cf313170bf580ef921b9c3df614f2fd57542c49e

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From cf313170bf580ef921b9c3df614f2fd57542c49e Mon Sep 17 00:00:00 2001
From: Maxime Coquelin <maxime.coquelin at redhat.com>
Date: Mon, 6 Feb 2023 16:07:33 +0100
Subject: [PATCH] vhost: decrease log level for unimplemented requests
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 43ccd55fdd6ab34b55060045594cc21aefa74383 ]

This patch changes VHOST_USER_SET_VRING_ERR and
VHOST_USER_SET_LOG_FD "not implemented" log levels from
INFO to DEBUG, as implementing these requests is not
mandatory. Having them being displayed at INFO level
may induce some confusion to the end-user.

Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions")

Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>
Acked-by: Kevin Traynor <ktraynor at redhat.com>
---
 lib/vhost/vhost_user.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 9902ae9944..76058c3ee5 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -1809,7 +1809,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,

 	if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
 		close(ctx->fds[0]);
-	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
+	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");

 	return RTE_VHOST_MSG_RESULT_OK;
 }
@@ -2326,7 +2326,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev,
 		return RTE_VHOST_MSG_RESULT_ERR;

 	close(ctx->fds[0]);
-	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n");
+	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n");

 	return RTE_VHOST_MSG_RESULT_OK;
 }
--
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-27 14:08:43.622360000 +0800
+++ 0085-vhost-decrease-log-level-for-unimplemented-requests.patch	2023-02-27 14:08:40.809237000 +0800
@@ -1 +1 @@
-From 43ccd55fdd6ab34b55060045594cc21aefa74383 Mon Sep 17 00:00:00 2001
+From cf313170bf580ef921b9c3df614f2fd57542c49e Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 43ccd55fdd6ab34b55060045594cc21aefa74383 ]
@@ -13 +15,0 @@
-Cc: stable at dpdk.org
@@ -23 +25 @@
-index 8c1d60b76b..b4236820a2 100644
+index 9902ae9944..76058c3ee5 100644
@@ -26 +28 @@
-@@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,
+@@ -1809,7 +1809,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,
@@ -35 +37 @@
-@@ -2340,7 +2340,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev,
+@@ -2326,7 +2326,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev,


More information about the stable mailing list