patch 'net/mlx5/hws: fix memory leak on general pool DB init' has been queued to stable release 22.11.2

Xueming Li xuemingl at nvidia.com
Mon Feb 27 08:00:34 CET 2023


Hi,

FYI, your patch has been queued to stable release 22.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/01/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=9e0308d5ef3c884ed4a76db16735d2dec2cfc279

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 9e0308d5ef3c884ed4a76db16735d2dec2cfc279 Mon Sep 17 00:00:00 2001
From: Alex Vesker <valex at nvidia.com>
Date: Wed, 11 Jan 2023 21:49:03 +0200
Subject: [PATCH] net/mlx5/hws: fix memory leak on general pool DB init
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 86ed522a82059896263ca8c7488403fccf62c6a7 ]

On elemend db init we allocated the element_manager
which was unused and not freed.

Fixes: b4dd7bcb0dcbe ("net/mlx5/hws: add pool and buddy")

Signed-off-by: Alex Vesker <valex at nvidia.com>
Reviewed-by: Erez Shitrit <erezsh at nvidia.com>
Acked-by: Matan Azrad <matan at nvidia.com>
---
 drivers/net/mlx5/hws/mlx5dr_pool.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/net/mlx5/hws/mlx5dr_pool.c b/drivers/net/mlx5/hws/mlx5dr_pool.c
index fdbd3d438d..af6a5c743b 100644
--- a/drivers/net/mlx5/hws/mlx5dr_pool.c
+++ b/drivers/net/mlx5/hws/mlx5dr_pool.c
@@ -464,13 +464,6 @@ static void mlx5dr_pool_general_element_db_uninit(struct mlx5dr_pool *pool)
  */
 static int mlx5dr_pool_general_element_db_init(struct mlx5dr_pool *pool)
 {
-	pool->db.element_manager = simple_calloc(1, sizeof(*pool->db.element_manager));
-	if (!pool->db.element_manager) {
-		DR_LOG(ERR, "No mem for general elemnt_manager");
-		rte_errno = ENOMEM;
-		return rte_errno;
-	}
-
 	pool->p_db_uninit = &mlx5dr_pool_general_element_db_uninit;
 	pool->p_get_chunk = &mlx5dr_pool_general_element_db_get_chunk;
 	pool->p_put_chunk = &mlx5dr_pool_general_element_db_put_chunk;
--
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-27 14:08:44.956006200 +0800
+++ 0127-net-mlx5-hws-fix-memory-leak-on-general-pool-DB-init.patch	2023-02-27 14:08:40.909237000 +0800
@@ -1 +1 @@
-From 86ed522a82059896263ca8c7488403fccf62c6a7 Mon Sep 17 00:00:00 2001
+From 9e0308d5ef3c884ed4a76db16735d2dec2cfc279 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 86ed522a82059896263ca8c7488403fccf62c6a7 ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list