patch 'table: fix action selector group size log2 setting' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Wed Mar 15 15:36:24 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/20/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/c07485a1c1770c484483a104c905336f7ca3b0ba

Thanks.

Kevin

---
>From c07485a1c1770c484483a104c905336f7ca3b0ba Mon Sep 17 00:00:00 2001
From: Yogesh Jangra <yogesh.jangra at intel.com>
Date: Thu, 9 Mar 2023 13:58:42 +0000
Subject: [PATCH] table: fix action selector group size log2 setting

[ upstream commit 44bcb29f5c1b5b5af1942dee58ba16fba78c35f0 ]

The incorrect variable for the number of groups was used, so in the
case of values not power of 2 the incorrect result was produced.

Fixes: f7598a62d114 ("table: support selector table")

Signed-off-by: Yogesh Jangra <yogesh.jangra at intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
---
 lib/table/rte_swx_table_selector.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/table/rte_swx_table_selector.c b/lib/table/rte_swx_table_selector.c
index 541ebc2213..5d8e013286 100644
--- a/lib/table/rte_swx_table_selector.c
+++ b/lib/table/rte_swx_table_selector.c
@@ -234,5 +234,5 @@ table_params_copy(struct table *t, struct rte_swx_table_selector_params *params)
 
 	for (i = 0; i < 32; i++)
-		if (params->n_members_per_group_max == 1U << i)
+		if (t->params.n_members_per_group_max == 1U << i)
 			t->n_members_per_group_max_log2 = i;
 
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-15 14:30:21.349567962 +0000
+++ 0031-table-fix-action-selector-group-size-log2-setting.patch	2023-03-15 14:30:20.596123738 +0000
@@ -1 +1 @@
-From 44bcb29f5c1b5b5af1942dee58ba16fba78c35f0 Mon Sep 17 00:00:00 2001
+From c07485a1c1770c484483a104c905336f7ca3b0ba Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 44bcb29f5c1b5b5af1942dee58ba16fba78c35f0 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index ad99f18453..18e021fe6f 100644
+index 541ebc2213..5d8e013286 100644
@@ -22 +23 @@
-@@ -233,5 +233,5 @@ table_params_copy(struct table *t, struct rte_swx_table_selector_params *params)
+@@ -234,5 +234,5 @@ table_params_copy(struct table *t, struct rte_swx_table_selector_params *params)



More information about the stable mailing list