patch 'app/crypto-perf: fix test file memory leak' has been queued to stable release 20.11.8

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 20.11.8

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/17/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/59852707e77878d03d1253ffa2ab283055b790e0

Thanks.

Luca Boccassi

---
>From 59852707e77878d03d1253ffa2ab283055b790e0 Mon Sep 17 00:00:00 2001
From: Ciara Power <ciara.power at intel.com>
Date: Fri, 10 Mar 2023 13:20:17 +0000
Subject: [PATCH] app/crypto-perf: fix test file memory leak

[ upstream commit 430c35730e09dea162b7830b4719285eb6f36364 ]

A memory leak was detected using the AddressSanitizer tool,
when running the crypto-perf application with a test vector file.

The strdup function used returns a pointer to a null-terminated byte
string, which must be freed after use. This patch frees the pointer in
an error case, and also after a successful run.

Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Ciara Power <ciara.power at intel.com>
Acked-by: Akhil Goyal <gakhil at marvell.com>
---
 app/test-crypto-perf/cperf_options_parsing.c     | 1 +
 app/test-crypto-perf/cperf_test_vector_parsing.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c
index e84f56cfaa..372cae343a 100644
--- a/app/test-crypto-perf/cperf_options_parsing.c
+++ b/app/test-crypto-perf/cperf_options_parsing.c
@@ -496,6 +496,7 @@ parse_test_file(struct cperf_options *opts,
 	if (access(opts->test_file, F_OK) != -1)
 		return 0;
 	RTE_LOG(ERR, USER1, "Test vector file doesn't exist\n");
+	free(opts->test_file);
 
 	return -1;
 }
diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c
index 1e9dfcfff0..1fe11df27b 100644
--- a/app/test-crypto-perf/cperf_test_vector_parsing.c
+++ b/app/test-crypto-perf/cperf_test_vector_parsing.c
@@ -28,6 +28,7 @@ free_test_vector(struct cperf_test_vector *vector, struct cperf_options *opts)
 		rte_free(vector->cipher_key.data);
 		rte_free(vector->auth_key.data);
 		rte_free(vector->ciphertext.data);
+		free(opts->test_file);
 	}
 
 	rte_free(vector);
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-15 22:44:51.800110186 +0000
+++ 0038-app-crypto-perf-fix-test-file-memory-leak.patch	2023-03-15 22:44:49.667852022 +0000
@@ -1 +1 @@
-From 430c35730e09dea162b7830b4719285eb6f36364 Mon Sep 17 00:00:00 2001
+From 59852707e77878d03d1253ffa2ab283055b790e0 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 430c35730e09dea162b7830b4719285eb6f36364 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index 8c9f632590..26136a52ae 100644
+index e84f56cfaa..372cae343a 100644
@@ -27 +28 @@
-@@ -519,6 +519,7 @@ parse_test_file(struct cperf_options *opts,
+@@ -496,6 +496,7 @@ parse_test_file(struct cperf_options *opts,
@@ -36 +37 @@
-index 98e46c3381..737d61d4af 100644
+index 1e9dfcfff0..1fe11df27b 100644
@@ -39 +40 @@
-@@ -30,6 +30,7 @@ free_test_vector(struct cperf_test_vector *vector, struct cperf_options *opts)
+@@ -28,6 +28,7 @@ free_test_vector(struct cperf_test_vector *vector, struct cperf_options *opts)