patch 'net/vhost: add missing newline in logs' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Wed Mar 22 11:31:56 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/24/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/14297e3110bb392e8acce99e0cb230994503e44c

Thanks.

Kevin

---
>From 14297e3110bb392e8acce99e0cb230994503e44c Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Thu, 9 Mar 2023 13:37:50 +0100
Subject: [PATCH] net/vhost: add missing newline in logs

[ upstream commit d539a20b7561d9e97d13f9b43d74ec030bd1a4ba ]

Fixes: 3f8ff12821e4 ("vhost: support interrupt mode")
Fixes: 8f1750f42e2d ("net/vhost: perform SW checksum in Rx path")
Fixes: 8ba1723783b2 ("net/vhost: perform SW checksum in Tx path")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>
---
 drivers/net/vhost/rte_eth_vhost.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index a280e788fb..ad2d52475d 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -621,5 +621,5 @@ eth_rxq_intr_disable(struct rte_eth_dev *dev, uint16_t qid)
 	ret = rte_vhost_get_vhost_vring(vq->vid, (qid << 1) + 1, &vring);
 	if (ret < 0) {
-		VHOST_LOG(ERR, "Failed to get rxq%d's vring", qid);
+		VHOST_LOG(ERR, "Failed to get rxq%d's vring\n", qid);
 		return ret;
 	}
@@ -821,5 +821,5 @@ new_device(int vid)
 			if (eth_vhost_install_intr(eth_dev) < 0) {
 				VHOST_LOG(INFO,
-					"Failed to install interrupt handler.");
+					"Failed to install interrupt handler.\n");
 					return -1;
 			}
@@ -1157,5 +1157,5 @@ eth_dev_start(struct rte_eth_dev *eth_dev)
 			if (eth_vhost_install_intr(eth_dev) < 0) {
 				VHOST_LOG(INFO,
-					"Failed to install interrupt handler.");
+					"Failed to install interrupt handler.\n");
 					return -1;
 			}
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-22 10:30:08.157065379 +0000
+++ 0009-net-vhost-add-missing-newline-in-logs.patch	2023-03-22 10:30:07.910866559 +0000
@@ -1 +1 @@
-From d539a20b7561d9e97d13f9b43d74ec030bd1a4ba Mon Sep 17 00:00:00 2001
+From 14297e3110bb392e8acce99e0cb230994503e44c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d539a20b7561d9e97d13f9b43d74ec030bd1a4ba ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org
@@ -14,2 +15,2 @@
- drivers/net/vhost/rte_eth_vhost.c | 10 +++++-----
- 1 file changed, 5 insertions(+), 5 deletions(-)
+ drivers/net/vhost/rte_eth_vhost.c | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
@@ -18 +19 @@
-index 9c609b45a3..198bf4d1f4 100644
+index a280e788fb..ad2d52475d 100644
@@ -21,15 +22 @@
-@@ -298,5 +298,5 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev)
- 		if (!(rxmode->offloads &
- 				(RTE_ETH_RX_OFFLOAD_UDP_CKSUM | RTE_ETH_RX_OFFLOAD_TCP_CKSUM))) {
--			VHOST_LOG(NOTICE, "Rx csum will be done in SW, may impact performance.");
-+			VHOST_LOG(NOTICE, "Rx csum will be done in SW, may impact performance.\n");
- 			internal->rx_sw_csum = true;
- 		}
-@@ -306,5 +306,5 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev)
- 		if (txmode->offloads &
- 				(RTE_ETH_TX_OFFLOAD_UDP_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_CKSUM)) {
--			VHOST_LOG(NOTICE, "Tx csum will be done in SW, may impact performance.");
-+			VHOST_LOG(NOTICE, "Tx csum will be done in SW, may impact performance.\n");
- 			internal->tx_sw_csum = true;
- 		}
-@@ -647,5 +647,5 @@ eth_rxq_intr_disable(struct rte_eth_dev *dev, uint16_t qid)
+@@ -621,5 +621,5 @@ eth_rxq_intr_disable(struct rte_eth_dev *dev, uint16_t qid)
@@ -42 +29 @@
-@@ -852,5 +852,5 @@ new_device(int vid)
+@@ -821,5 +821,5 @@ new_device(int vid)
@@ -49 +36 @@
-@@ -1192,5 +1192,5 @@ eth_dev_start(struct rte_eth_dev *eth_dev)
+@@ -1157,5 +1157,5 @@ eth_dev_start(struct rte_eth_dev *eth_dev)



More information about the stable mailing list