patch 'test/crypto: fix statistics error messages' has been queued to stable release 20.11.8
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Wed Mar 29 03:04:42 CEST 2023
Hi,
FYI, your patch has been queued to stable release 20.11.8
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/31/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/21d71fb87106deef57df3f7e0cbbd1ae39efa717
Thanks.
Luca Boccassi
---
>From 21d71fb87106deef57df3f7e0cbbd1ae39efa717 Mon Sep 17 00:00:00 2001
From: Saoirse O'Donovan <saoirse.odonovan at intel.com>
Date: Mon, 20 Mar 2023 09:29:56 +0000
Subject: [PATCH] test/crypto: fix statistics error messages
[ upstream commit 051af8d174dd0f100f407269c25c007216c912ad ]
The test stats testcase was printing the same error message for
multiple errors in the test stats testcase. This is now replaced
with descriptive error messages, which match the cause of the failure.
Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
Signed-off-by: Saoirse O'Donovan <saoirse.odonovan at intel.com>
Acked-by: Ciara Power <ciara.power at intel.com>
---
app/test/test_cryptodev.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 15675df2d5..e43ad30bc8 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -10172,11 +10172,11 @@ test_stats(void)
TEST_ASSERT((stats.enqueued_count == 1),
"rte_cryptodev_stats_get returned unexpected enqueued stat");
TEST_ASSERT((stats.dequeued_count == 1),
- "rte_cryptodev_stats_get returned unexpected enqueued stat");
+ "rte_cryptodev_stats_get returned unexpected dequeued stat");
TEST_ASSERT((stats.enqueue_err_count == 0),
- "rte_cryptodev_stats_get returned unexpected enqueued stat");
+ "rte_cryptodev_stats_get returned unexpected enqueued error count stat");
TEST_ASSERT((stats.dequeue_err_count == 0),
- "rte_cryptodev_stats_get returned unexpected enqueued stat");
+ "rte_cryptodev_stats_get returned unexpected dequeued error count stat");
/* invalid device but should ignore and not reset device stats*/
rte_cryptodev_stats_reset(ts_params->valid_devs[0] + 300);
@@ -10184,7 +10184,7 @@ test_stats(void)
&stats),
"rte_cryptodev_stats_get failed");
TEST_ASSERT((stats.enqueued_count == 1),
- "rte_cryptodev_stats_get returned unexpected enqueued stat");
+ "rte_cryptodev_stats_get returned unexpected enqueued stat after invalid reset");
/* check that a valid reset clears stats */
rte_cryptodev_stats_reset(ts_params->valid_devs[0]);
@@ -10192,9 +10192,9 @@ test_stats(void)
&stats),
"rte_cryptodev_stats_get failed");
TEST_ASSERT((stats.enqueued_count == 0),
- "rte_cryptodev_stats_get returned unexpected enqueued stat");
+ "rte_cryptodev_stats_get returned unexpected enqueued stat after valid reset");
TEST_ASSERT((stats.dequeued_count == 0),
- "rte_cryptodev_stats_get returned unexpected enqueued stat");
+ "rte_cryptodev_stats_get returned unexpected dequeued stat after valid reset");
return TEST_SUCCESS;
}
--
2.39.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-03-29 01:31:22.829092261 +0100
+++ 0006-test-crypto-fix-statistics-error-messages.patch 2023-03-29 01:31:22.506039977 +0100
@@ -1 +1 @@
-From 051af8d174dd0f100f407269c25c007216c912ad Mon Sep 17 00:00:00 2001
+From 21d71fb87106deef57df3f7e0cbbd1ae39efa717 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 051af8d174dd0f100f407269c25c007216c912ad ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -16 +16,0 @@
- .mailmap | 1 +
@@ -18 +18 @@
- 2 files changed, 7 insertions(+), 6 deletions(-)
+ 1 file changed, 6 insertions(+), 6 deletions(-)
@@ -20,12 +19,0 @@
-diff --git a/.mailmap b/.mailmap
-index dc30369117..cac02a6f48 100644
---- a/.mailmap
-+++ b/.mailmap
-@@ -1182,6 +1182,7 @@ Sangjin Han <sangjin at eecs.berkeley.edu>
- Sankar Chokkalingam <sankarx.chokkalingam at intel.com>
- Santoshkumar Karanappa Rastapur <santosh.rastapur at broadcom.com>
- Santosh Shukla <santosh.shukla at caviumnetworks.com> <sshukla at mvista.com>
-+Saoirse O'Donovan <saoirse.odonovan at intel.com>
- Saori Usami <susami at igel.co.jp>
- Sarath Somasekharan <sarathx.somasekharan at intel.com>
- Sarosh Arif <sarosh.arif at emumba.com>
@@ -33 +21 @@
-index f4648755e5..9c670e9a35 100644
+index 15675df2d5..e43ad30bc8 100644
@@ -36 +24 @@
-@@ -12341,11 +12341,11 @@ test_stats(void)
+@@ -10172,11 +10172,11 @@ test_stats(void)
@@ -51 +39 @@
-@@ -12353,7 +12353,7 @@ test_stats(void)
+@@ -10184,7 +10184,7 @@ test_stats(void)
@@ -60 +48 @@
-@@ -12361,9 +12361,9 @@ test_stats(void)
+@@ -10192,9 +10192,9 @@ test_stats(void)
More information about the stable
mailing list