patch 'net/iavf: fix checksum offloading' has been queued to stable release 21.11.6

Kevin Traynor ktraynor at redhat.com
Thu Nov 2 14:12:02 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/08/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/bf23d4ca4785eef62723969dd03b3826975b2509

Thanks.

Kevin

---
>From bf23d4ca4785eef62723969dd03b3826975b2509 Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Wed, 23 Aug 2023 08:29:11 +0200
Subject: [PATCH] net/iavf: fix checksum offloading

[ upstream commit 3c715591ece0771b7a5503ffe5340c6f3cc1cb62 ]

l2_len and l3_len fields are related to Tx offloading features.

It is undefined in the DPDK API what those fields may contain if an
application did not request a Tx offload.

Skip reading them if no Tx offloads has been requested.

Fixes: 1e728b01120c ("net/iavf: rework Tx path")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Qi Zhang <qi.z.zhang at intel.com>
---
 drivers/net/iavf/iavf_rxtx.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index 19b46b2a5d..1881f97803 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -2441,4 +2441,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1,
 	}
 
+	if ((m->ol_flags & IAVF_TX_CKSUM_OFFLOAD_MASK) == 0)
+		goto skip_cksum;
+
 	/* Set MACLEN */
 	offset |= (m->l2_len >> 1) << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;
@@ -2494,4 +2497,5 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1,
 	}
 
+skip_cksum:
 	*qw1 = rte_cpu_to_le_64((((uint64_t)command <<
 		IAVF_TXD_DATA_QW1_CMD_SHIFT) & IAVF_TXD_DATA_QW1_CMD_MASK) |
-- 
2.41.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-11-02 13:09:42.189140254 +0000
+++ 0056-net-iavf-fix-checksum-offloading.patch	2023-11-02 13:09:40.864163499 +0000
@@ -1 +1 @@
-From 3c715591ece0771b7a5503ffe5340c6f3cc1cb62 Mon Sep 17 00:00:00 2001
+From bf23d4ca4785eef62723969dd03b3826975b2509 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 3c715591ece0771b7a5503ffe5340c6f3cc1cb62 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index f7df4665d1..33b0f9f482 100644
+index 19b46b2a5d..1881f97803 100644
@@ -26 +27 @@
-@@ -2644,4 +2644,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1,
+@@ -2441,4 +2441,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1,
@@ -33,2 +34,2 @@
- 	if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK &&
-@@ -2703,4 +2706,5 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1,
+ 	offset |= (m->l2_len >> 1) << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;
+@@ -2494,4 +2497,5 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1,



More information about the stable mailing list