patch 'net/softnic: fix Rx and Tx queue state' has been queued to stable release 21.11.6

Kevin Traynor ktraynor at redhat.com
Thu Nov 2 14:12:42 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/08/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/4e0e44f7ef09a21d4ee57cc36786f2e6f845db60

Thanks.

Kevin

---
>From 4e0e44f7ef09a21d4ee57cc36786f2e6f845db60 Mon Sep 17 00:00:00 2001
From: Jie Hai <haijie1 at huawei.com>
Date: Fri, 8 Sep 2023 19:28:56 +0800
Subject: [PATCH] net/softnic: fix Rx and Tx queue state

[ upstream commit 7143a21342ef611a4159f03f24f0c4fbd8686aa1 ]

The DPDK framework reports the queue state, which is stored in
dev->data->tx_queue_state and dev->data->rx_queue_state. The
state is maintained by the driver. Users may determine whether
a queue participates in packet forwarding based on the state.
Therefore, the driver needs to modify the queue state in time
according to the actual situation.

Fixes: 9ad9ff476cac ("ethdev: add queue state in queried queue information")

Signed-off-by: Jie Hai <haijie1 at huawei.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
---
 drivers/net/softnic/rte_eth_softnic.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c
index 8c098cad5b..009cc911f4 100644
--- a/drivers/net/softnic/rte_eth_softnic.c
+++ b/drivers/net/softnic/rte_eth_softnic.c
@@ -165,4 +165,5 @@ pmd_dev_start(struct rte_eth_dev *dev)
 	struct pmd_internals *p = dev->data->dev_private;
 	int status;
+	uint16_t i;
 
 	/* Firmware */
@@ -177,4 +178,9 @@ pmd_dev_start(struct rte_eth_dev *dev)
 	dev->data->dev_link.link_status = RTE_ETH_LINK_UP;
 
+	for (i = 0; i < dev->data->nb_rx_queues; i++)
+		dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
+	for (i = 0; i < dev->data->nb_tx_queues; i++)
+		dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
+
 	return 0;
 }
@@ -184,4 +190,5 @@ pmd_dev_stop(struct rte_eth_dev *dev)
 {
 	struct pmd_internals *p = dev->data->dev_private;
+	uint16_t i;
 
 	/* Link DOWN */
@@ -202,4 +209,9 @@ pmd_dev_stop(struct rte_eth_dev *dev)
 	softnic_mtr_free(p);
 
+	for (i = 0; i < dev->data->nb_rx_queues; i++)
+		dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
+	for (i = 0; i < dev->data->nb_tx_queues; i++)
+		dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
+
 	return 0;
 }
-- 
2.41.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-11-02 13:09:43.097025992 +0000
+++ 0096-net-softnic-fix-Rx-and-Tx-queue-state.patch	2023-11-02 13:09:40.915163663 +0000
@@ -1 +1 @@
-From 7143a21342ef611a4159f03f24f0c4fbd8686aa1 Mon Sep 17 00:00:00 2001
+From 4e0e44f7ef09a21d4ee57cc36786f2e6f845db60 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 7143a21342ef611a4159f03f24f0c4fbd8686aa1 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index bcf6664460..1b90cf7a21 100644
+index 8c098cad5b..009cc911f4 100644
@@ -26 +27 @@
-@@ -135,4 +135,5 @@ pmd_dev_start(struct rte_eth_dev *dev)
+@@ -165,4 +165,5 @@ pmd_dev_start(struct rte_eth_dev *dev)
@@ -32 +33 @@
-@@ -147,4 +148,9 @@ pmd_dev_start(struct rte_eth_dev *dev)
+@@ -177,4 +178,9 @@ pmd_dev_start(struct rte_eth_dev *dev)
@@ -42 +43 @@
-@@ -154,4 +160,5 @@ pmd_dev_stop(struct rte_eth_dev *dev)
+@@ -184,4 +190,5 @@ pmd_dev_stop(struct rte_eth_dev *dev)
@@ -48,2 +49,2 @@
-@@ -164,4 +171,9 @@ pmd_dev_stop(struct rte_eth_dev *dev)
- 	softnic_mempool_free(p);
+@@ -202,4 +209,9 @@ pmd_dev_stop(struct rte_eth_dev *dev)
+ 	softnic_mtr_free(p);



More information about the stable mailing list