patch 'test/bonding: add missing check' has been queued to stable release 20.11.10
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Wed Nov 8 20:25:13 CET 2023
Hi,
FYI, your patch has been queued to stable release 20.11.10
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/10/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/894b6863a30800d67b9d19c7ffdbbbcfdefb6ef8
Thanks.
Luca Boccassi
---
>From 894b6863a30800d67b9d19c7ffdbbbcfdefb6ef8 Mon Sep 17 00:00:00 2001
From: Long Wu <long.wu at corigine.com>
Date: Tue, 10 Oct 2023 14:23:04 +0800
Subject: [PATCH] test/bonding: add missing check
[ upstream commit 0ecafc2e44268e4d0626dcf0c811590466291f20 ]
CI found the function without checking return value in this place.
Coverity issue: 403101
Fixes: 92073ef961ee ("bond: unit tests")
Signed-off-by: Long Wu <long.wu at corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he at corigine.com>
Reviewed-by: Peng Zhang <peng.zhang at corigine.com>
Acked-by: Ferruh Yigit <ferruh.yigit at amd.com>
---
app/test/test_link_bonding.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
index 4f810efb0a..886fe1680e 100644
--- a/app/test/test_link_bonding.c
+++ b/app/test/test_link_bonding.c
@@ -445,7 +445,8 @@ test_add_already_bonded_slave_to_bonded_device(void)
uint16_t slaves[RTE_MAX_ETHPORTS];
char pmd_name[RTE_ETH_NAME_MAX_LEN];
- test_add_slave_to_bonded_device();
+ TEST_ASSERT_SUCCESS(test_add_slave_to_bonded_device(),
+ "Failed to add member to bonding device");
current_slave_count = rte_eth_bond_slaves_get(test_params->bonded_port_id,
slaves, RTE_MAX_ETHPORTS);
--
2.39.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-11-08 19:23:52.784869629 +0000
+++ 0015-test-bonding-add-missing-check.patch 2023-11-08 19:23:51.777396376 +0000
@@ -1 +1 @@
-From 0ecafc2e44268e4d0626dcf0c811590466291f20 Mon Sep 17 00:00:00 2001
+From 894b6863a30800d67b9d19c7ffdbbbcfdefb6ef8 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 0ecafc2e44268e4d0626dcf0c811590466291f20 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 4d715c4465..4d54706c21 100644
+index 4f810efb0a..886fe1680e 100644
@@ -24,2 +25,2 @@
-@@ -449,7 +449,8 @@ test_add_already_bonding_member_to_bonding_device(void)
- uint16_t members[RTE_MAX_ETHPORTS];
+@@ -445,7 +445,8 @@ test_add_already_bonded_slave_to_bonded_device(void)
+ uint16_t slaves[RTE_MAX_ETHPORTS];
@@ -28,2 +29,2 @@
-- test_add_member_to_bonding_device();
-+ TEST_ASSERT_SUCCESS(test_add_member_to_bonding_device(),
+- test_add_slave_to_bonded_device();
++ TEST_ASSERT_SUCCESS(test_add_slave_to_bonded_device(),
@@ -32,2 +33,2 @@
- current_member_count = rte_eth_bond_members_get(test_params->bonding_port_id,
- members, RTE_MAX_ETHPORTS);
+ current_slave_count = rte_eth_bond_slaves_get(test_params->bonded_port_id,
+ slaves, RTE_MAX_ETHPORTS);
More information about the stable
mailing list