patch 'app/testpmd: add explicit check for tunnel TSO' has been queued to stable release 20.11.10
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Wed Nov 15 12:45:09 CET 2023
Hi,
FYI, your patch has been queued to stable release 20.11.10
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/17/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/d6dd9c8ce5595b3deeffbf452f3ff292336793fc
Thanks.
Luca Boccassi
---
>From d6dd9c8ce5595b3deeffbf452f3ff292336793fc Mon Sep 17 00:00:00 2001
From: Huisong Li <lihuisong at huawei.com>
Date: Sat, 11 Nov 2023 12:59:42 +0800
Subject: [PATCH] app/testpmd: add explicit check for tunnel TSO
[ upstream commit 33156a6bc61560e74a126ade38a7af9c1fa02671 ]
If port don't support TSO of tunnel packets, tell user in advance and no
need to change other configuration of this port in case of fault spread.
In addition, if some tunnel offloads don't support, which is not an
error case, the log about this shouldn't be to stderr.
Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check")
Signed-off-by: Huisong Li <lihuisong at huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at amd.com>
---
app/test-pmd/cmdline.c | 61 +++++++++++++++++++++---------------------
1 file changed, 30 insertions(+), 31 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index e8b680defe..e9d8d375f5 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -4942,23 +4942,23 @@ static void
check_tunnel_tso_nic_support(portid_t port_id, uint64_t tx_offload_capa)
{
if (!(tx_offload_capa & DEV_TX_OFFLOAD_VXLAN_TNL_TSO))
- printf("Warning: VXLAN TUNNEL TSO not supported therefore "
- "not enabled for port %d\n", port_id);
+ printf("Warning: VXLAN TUNNEL TSO not supported therefore not enabled for port %d\n",
+ port_id);
if (!(tx_offload_capa & DEV_TX_OFFLOAD_GRE_TNL_TSO))
- printf("Warning: GRE TUNNEL TSO not supported therefore "
- "not enabled for port %d\n", port_id);
+ printf("Warning: GRE TUNNEL TSO not supported therefore not enabled for port %d\n",
+ port_id);
if (!(tx_offload_capa & DEV_TX_OFFLOAD_IPIP_TNL_TSO))
- printf("Warning: IPIP TUNNEL TSO not supported therefore "
- "not enabled for port %d\n", port_id);
+ printf("Warning: IPIP TUNNEL TSO not supported therefore not enabled for port %d\n",
+ port_id);
if (!(tx_offload_capa & DEV_TX_OFFLOAD_GENEVE_TNL_TSO))
- printf("Warning: GENEVE TUNNEL TSO not supported therefore "
- "not enabled for port %d\n", port_id);
+ printf("Warning: GENEVE TUNNEL TSO not supported therefore not enabled for port %d\n",
+ port_id);
if (!(tx_offload_capa & DEV_TX_OFFLOAD_IP_TNL_TSO))
- printf("Warning: IP TUNNEL TSO not supported therefore "
- "not enabled for port %d\n", port_id);
+ printf("Warning: IP TUNNEL TSO not supported therefore not enabled for port %d\n",
+ port_id);
if (!(tx_offload_capa & DEV_TX_OFFLOAD_UDP_TNL_TSO))
- printf("Warning: UDP TUNNEL TSO not supported therefore "
- "not enabled for port %d\n", port_id);
+ printf("Warning: UDP TUNNEL TSO not supported therefore not enabled for port %d\n",
+ port_id);
}
static void
@@ -4968,6 +4968,12 @@ cmd_tunnel_tso_set_parsed(void *parsed_result,
{
struct cmd_tunnel_tso_set_result *res = parsed_result;
struct rte_eth_dev_info dev_info;
+ uint64_t all_tunnel_tso = DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
+ DEV_TX_OFFLOAD_GRE_TNL_TSO |
+ DEV_TX_OFFLOAD_IPIP_TNL_TSO |
+ DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+ DEV_TX_OFFLOAD_IP_TNL_TSO |
+ DEV_TX_OFFLOAD_UDP_TNL_TSO;
int ret;
if (port_id_is_invalid(res->port_id, ENABLED_WARN))
@@ -4980,30 +4986,23 @@ cmd_tunnel_tso_set_parsed(void *parsed_result,
if (!strcmp(res->mode, "set"))
ports[res->port_id].tunnel_tso_segsz = res->tso_segsz;
- ret = eth_dev_info_get_print_err(res->port_id, &dev_info);
- if (ret != 0)
- return;
-
- check_tunnel_tso_nic_support(res->port_id, dev_info.tx_offload_capa);
if (ports[res->port_id].tunnel_tso_segsz == 0) {
- ports[res->port_id].dev_conf.txmode.offloads &=
- ~(DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
- DEV_TX_OFFLOAD_GRE_TNL_TSO |
- DEV_TX_OFFLOAD_IPIP_TNL_TSO |
- DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
- DEV_TX_OFFLOAD_IP_TNL_TSO |
- DEV_TX_OFFLOAD_UDP_TNL_TSO);
+ ports[res->port_id].dev_conf.txmode.offloads &= ~all_tunnel_tso;
printf("TSO for tunneled packets is disabled\n");
} else {
- uint64_t tso_offloads = (DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
- DEV_TX_OFFLOAD_GRE_TNL_TSO |
- DEV_TX_OFFLOAD_IPIP_TNL_TSO |
- DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
- DEV_TX_OFFLOAD_IP_TNL_TSO |
- DEV_TX_OFFLOAD_UDP_TNL_TSO);
+ ret = eth_dev_info_get_print_err(res->port_id, &dev_info);
+ if (ret != 0)
+ return;
+
+ if ((all_tunnel_tso & dev_info.tx_offload_capa) == 0) {
+ fprintf(stderr, "Error: port=%u don't support tunnel TSO offloads.\n",
+ res->port_id);
+ return;
+ }
+ check_tunnel_tso_nic_support(res->port_id, dev_info.tx_offload_capa);
ports[res->port_id].dev_conf.txmode.offloads |=
- (tso_offloads & dev_info.tx_offload_capa);
+ (all_tunnel_tso & dev_info.tx_offload_capa);
printf("TSO segment size for tunneled packets is %d\n",
ports[res->port_id].tunnel_tso_segsz);
--
2.39.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-11-15 11:44:14.026435564 +0000
+++ 0010-app-testpmd-add-explicit-check-for-tunnel-TSO.patch 2023-11-15 11:44:13.586387858 +0000
@@ -1 +1 @@
-From 33156a6bc61560e74a126ade38a7af9c1fa02671 Mon Sep 17 00:00:00 2001
+From d6dd9c8ce5595b3deeffbf452f3ff292336793fc Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 33156a6bc61560e74a126ade38a7af9c1fa02671 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -18,2 +19,2 @@
- app/test-pmd/cmdline.c | 55 ++++++++++++++++++------------------------
- 1 file changed, 24 insertions(+), 31 deletions(-)
+ app/test-pmd/cmdline.c | 61 +++++++++++++++++++++---------------------
+ 1 file changed, 30 insertions(+), 31 deletions(-)
@@ -22 +23 @@
-index 1fffb07db1..2e3365557a 100644
+index e8b680defe..e9d8d375f5 100644
@@ -25 +26 @@
-@@ -5039,28 +5039,22 @@ static void
+@@ -4942,23 +4942,23 @@ static void
@@ -28,3 +29,3 @@
- if (!(tx_offload_capa & RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO))
-- fprintf(stderr,
-- "Warning: VXLAN TUNNEL TSO not supported therefore not enabled for port %d\n",
+ if (!(tx_offload_capa & DEV_TX_OFFLOAD_VXLAN_TNL_TSO))
+- printf("Warning: VXLAN TUNNEL TSO not supported therefore "
+- "not enabled for port %d\n", port_id);
@@ -32,4 +33,4 @@
- port_id);
- if (!(tx_offload_capa & RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO))
-- fprintf(stderr,
-- "Warning: GRE TUNNEL TSO not supported therefore not enabled for port %d\n",
++ port_id);
+ if (!(tx_offload_capa & DEV_TX_OFFLOAD_GRE_TNL_TSO))
+- printf("Warning: GRE TUNNEL TSO not supported therefore "
+- "not enabled for port %d\n", port_id);
@@ -37,4 +38,4 @@
- port_id);
- if (!(tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO))
-- fprintf(stderr,
-- "Warning: IPIP TUNNEL TSO not supported therefore not enabled for port %d\n",
++ port_id);
+ if (!(tx_offload_capa & DEV_TX_OFFLOAD_IPIP_TNL_TSO))
+- printf("Warning: IPIP TUNNEL TSO not supported therefore "
+- "not enabled for port %d\n", port_id);
@@ -42,4 +43,4 @@
- port_id);
- if (!(tx_offload_capa & RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO))
-- fprintf(stderr,
-- "Warning: GENEVE TUNNEL TSO not supported therefore not enabled for port %d\n",
++ port_id);
+ if (!(tx_offload_capa & DEV_TX_OFFLOAD_GENEVE_TNL_TSO))
+- printf("Warning: GENEVE TUNNEL TSO not supported therefore "
+- "not enabled for port %d\n", port_id);
@@ -47,4 +48,4 @@
- port_id);
- if (!(tx_offload_capa & RTE_ETH_TX_OFFLOAD_IP_TNL_TSO))
-- fprintf(stderr,
-- "Warning: IP TUNNEL TSO not supported therefore not enabled for port %d\n",
++ port_id);
+ if (!(tx_offload_capa & DEV_TX_OFFLOAD_IP_TNL_TSO))
+- printf("Warning: IP TUNNEL TSO not supported therefore "
+- "not enabled for port %d\n", port_id);
@@ -52,4 +53,4 @@
- port_id);
- if (!(tx_offload_capa & RTE_ETH_TX_OFFLOAD_UDP_TNL_TSO))
-- fprintf(stderr,
-- "Warning: UDP TUNNEL TSO not supported therefore not enabled for port %d\n",
++ port_id);
+ if (!(tx_offload_capa & DEV_TX_OFFLOAD_UDP_TNL_TSO))
+- printf("Warning: UDP TUNNEL TSO not supported therefore "
+- "not enabled for port %d\n", port_id);
@@ -57 +58 @@
- port_id);
++ port_id);
@@ -60 +61,2 @@
-@@ -5071,6 +5065,12 @@ cmd_tunnel_tso_set_parsed(void *parsed_result,
+ static void
+@@ -4968,6 +4968,12 @@ cmd_tunnel_tso_set_parsed(void *parsed_result,
@@ -64,6 +66,6 @@
-+ uint64_t all_tunnel_tso = RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
-+ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
-+ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
-+ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO |
-+ RTE_ETH_TX_OFFLOAD_IP_TNL_TSO |
-+ RTE_ETH_TX_OFFLOAD_UDP_TNL_TSO;
++ uint64_t all_tunnel_tso = DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
++ DEV_TX_OFFLOAD_GRE_TNL_TSO |
++ DEV_TX_OFFLOAD_IPIP_TNL_TSO |
++ DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
++ DEV_TX_OFFLOAD_IP_TNL_TSO |
++ DEV_TX_OFFLOAD_UDP_TNL_TSO;
@@ -73 +75 @@
-@@ -5083,30 +5083,23 @@ cmd_tunnel_tso_set_parsed(void *parsed_result,
+@@ -4980,30 +4986,23 @@ cmd_tunnel_tso_set_parsed(void *parsed_result,
@@ -84,6 +86,6 @@
-- ~(RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
-- RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
-- RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
-- RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO |
-- RTE_ETH_TX_OFFLOAD_IP_TNL_TSO |
-- RTE_ETH_TX_OFFLOAD_UDP_TNL_TSO);
+- ~(DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
+- DEV_TX_OFFLOAD_GRE_TNL_TSO |
+- DEV_TX_OFFLOAD_IPIP_TNL_TSO |
+- DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+- DEV_TX_OFFLOAD_IP_TNL_TSO |
+- DEV_TX_OFFLOAD_UDP_TNL_TSO);
@@ -93,6 +95,6 @@
-- uint64_t tso_offloads = (RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
-- RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
-- RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
-- RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO |
-- RTE_ETH_TX_OFFLOAD_IP_TNL_TSO |
-- RTE_ETH_TX_OFFLOAD_UDP_TNL_TSO);
+- uint64_t tso_offloads = (DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
+- DEV_TX_OFFLOAD_GRE_TNL_TSO |
+- DEV_TX_OFFLOAD_IPIP_TNL_TSO |
+- DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+- DEV_TX_OFFLOAD_IP_TNL_TSO |
+- DEV_TX_OFFLOAD_UDP_TNL_TSO);
More information about the stable
mailing list