patch 'net/virtio: fix link state interrupt vector setting' has been queued to stable release 21.11.6
Kevin Traynor
ktraynor at redhat.com
Thu Nov 16 14:22:46 CET 2023
Hi,
FYI, your patch has been queued to stable release 21.11.6
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/21/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/98857c5b76557096397f802c72690a2235005b7c
Thanks.
Kevin
---
>From 98857c5b76557096397f802c72690a2235005b7c Mon Sep 17 00:00:00 2001
From: Wenwu Ma <wenwux.ma at intel.com>
Date: Mon, 23 Oct 2023 09:46:12 +0800
Subject: [PATCH] net/virtio: fix link state interrupt vector setting
[ upstream commit efc3f842b3dd69c4e65dbdf6cdaccde8c759b5d9 ]
Setting the vector for link state interrupts should be
done before the device initialization is completed.
Fixes: ee85024cf5f7 ("net/virtio: complete init stage at the right place")
Signed-off-by: Wenwu Ma <wenwux.ma at intel.com>
Tested-by: Wei Ling <weix.ling at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
drivers/net/virtio/virtio_ethdev.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index a23559850c..2a35024250 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -2356,4 +2356,12 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t req_features)
}
+ if (eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
+ /* Enable vector (0) for Link State Interrupt */
+ if (VIRTIO_OPS(hw)->set_config_irq(hw, 0) ==
+ VIRTIO_MSI_NO_VECTOR) {
+ PMD_DRV_LOG(ERR, "failed to set config vector");
+ return -EBUSY;
+ }
+
virtio_reinit_complete(hw);
@@ -2675,12 +2683,4 @@ virtio_dev_configure(struct rte_eth_dev *dev)
hw->has_rx_offload = rx_offload_enabled(hw);
- if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
- /* Enable vector (0) for Link State Interrupt */
- if (VIRTIO_OPS(hw)->set_config_irq(hw, 0) ==
- VIRTIO_MSI_NO_VECTOR) {
- PMD_DRV_LOG(ERR, "failed to set config vector");
- return -EBUSY;
- }
-
if (virtio_with_packed_queue(hw)) {
#if defined(RTE_ARCH_X86_64) && defined(CC_AVX512_SUPPORT)
--
2.41.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-11-16 13:21:52.690300303 +0000
+++ 0004-net-virtio-fix-link-state-interrupt-vector-setting.patch 2023-11-16 13:21:52.396946218 +0000
@@ -1 +1 @@
-From efc3f842b3dd69c4e65dbdf6cdaccde8c759b5d9 Mon Sep 17 00:00:00 2001
+From 98857c5b76557096397f802c72690a2235005b7c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit efc3f842b3dd69c4e65dbdf6cdaccde8c759b5d9 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 3ab56ef769..c2c0a1a111 100644
+index a23559850c..2a35024250 100644
@@ -23 +24 @@
-@@ -1913,4 +1913,12 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t req_features)
+@@ -2356,4 +2356,12 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t req_features)
@@ -36 +37 @@
-@@ -2238,12 +2246,4 @@ virtio_dev_configure(struct rte_eth_dev *dev)
+@@ -2675,12 +2683,4 @@ virtio_dev_configure(struct rte_eth_dev *dev)
More information about the stable
mailing list