[PATCH v3] net/gve : Update EOP & csum bit in txd rte_mbuf chain

Stephen Hemminger stephen at networkplumber.org
Thu Aug 1 20:54:49 CEST 2024


On Thu,  1 Aug 2024 17:27:53 +0000
Tathagat Priyadarshi <tathagat.dpdk at gmail.com> wrote:

> +		if (ol_flags & GVE_TX_CKSUM_OFFLOAD_MASK_DQO)
> +			csum = 1;
> +		else
> +			cusm = 0;
> +

Obvious typo, did you do a final test build?

Could also use logical inverse operator instead of if() which will
generate better code sometimes.
		
		csum = !!(ol_flags & GVE_TX_CKSUM_OFFLOAD_MASK_DQO);



More information about the stable mailing list