patch 'graph: fix mcore dispatch walk' has been queued to stable release 23.11.2
Xueming Li
xuemingl at nvidia.com
Mon Aug 12 14:48:06 CEST 2024
Hi,
FYI, your patch has been queued to stable release 23.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/14/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=c13a819a446733582988f12bda50d35b02f15b62
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From c13a819a446733582988f12bda50d35b02f15b62 Mon Sep 17 00:00:00 2001
From: Jingjing Wu <jingjing.wu at intel.com>
Date: Fri, 22 Mar 2024 15:46:37 +0000
Subject: [PATCH] graph: fix mcore dispatch walk
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 19c34a3caee965e60f25fb4de6553607b894ba72 ]
Head move happens before the core id check, which will cause the last
source node be executed even core id is not correct. This patch changes
head check to less than 1 instead of 0 to fix this issue.
Fixes: 35dfd9b9fd85 ("graph: introduce graph walk by cross-core dispatch")
Signed-off-by: Jingjing Wu <jingjing.wu at intel.com>
Acked-by: Zhirun Yan <zhirun.yan at intel.com>
---
lib/graph/rte_graph_model_mcore_dispatch.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/graph/rte_graph_model_mcore_dispatch.h b/lib/graph/rte_graph_model_mcore_dispatch.h
index 75ec388cad..732b89297f 100644
--- a/lib/graph/rte_graph_model_mcore_dispatch.h
+++ b/lib/graph/rte_graph_model_mcore_dispatch.h
@@ -100,7 +100,7 @@ rte_graph_walk_mcore_dispatch(struct rte_graph *graph)
node = (struct rte_node *)RTE_PTR_ADD(graph, cir_start[(int32_t)head++]);
/* skip the src nodes which not bind with current worker */
- if ((int32_t)head < 0 && node->dispatch.lcore_id != graph->dispatch.lcore_id)
+ if ((int32_t)head < 1 && node->dispatch.lcore_id != graph->dispatch.lcore_id)
continue;
/* Schedule the node until all task/objs are done */
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-08-12 20:44:02.921460657 +0800
+++ 0009-graph-fix-mcore-dispatch-walk.patch 2024-08-12 20:44:01.895069255 +0800
@@ -1 +1 @@
-From 19c34a3caee965e60f25fb4de6553607b894ba72 Mon Sep 17 00:00:00 2001
+From c13a819a446733582988f12bda50d35b02f15b62 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 19c34a3caee965e60f25fb4de6553607b894ba72 ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list