patch 'net/mana: fix uninitialized return value' has been queued to stable release 23.11.2

Xueming Li xuemingl at nvidia.com
Mon Aug 12 14:49:06 CEST 2024


Hi,

FYI, your patch has been queued to stable release 23.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/14/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=708d5a261b673590204842dda9988a18a649fd25

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 708d5a261b673590204842dda9988a18a649fd25 Mon Sep 17 00:00:00 2001
From: Mahmoud Maatuq <mahmoudmatook.mm at gmail.com>
Date: Thu, 13 Jun 2024 22:30:39 +0400
Subject: [PATCH] net/mana: fix uninitialized return value
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit c2c0c8af08ed4e37a10bbabf98a09a105a5650a8 ]

in case we didn't enter or finished the loop without getting ifname we
ret shouldn't have an arbitrary value.

Coverity issue: 424690
Fixes: 84497839d9ca ("net/mana: support MTU update")

Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm at gmail.com>
Reviewed-by: Long Li <longli at microsoft.com>
---
 drivers/net/mana/mana.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c
index 58257c971e..65ca139be5 100644
--- a/drivers/net/mana/mana.c
+++ b/drivers/net/mana/mana.c
@@ -711,7 +711,7 @@ mana_dev_stats_reset(struct rte_eth_dev *dev __rte_unused)
 static int
 mana_get_ifname(const struct mana_priv *priv, char (*ifname)[IF_NAMESIZE])
 {
-	int ret;
+	int ret = -ENODEV;
 	DIR *dir;
 	struct dirent *dent;
 
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-08-12 20:44:04.805287417 +0800
+++ 0069-net-mana-fix-uninitialized-return-value.patch	2024-08-12 20:44:02.165069308 +0800
@@ -1 +1 @@
-From c2c0c8af08ed4e37a10bbabf98a09a105a5650a8 Mon Sep 17 00:00:00 2001
+From 708d5a261b673590204842dda9988a18a649fd25 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit c2c0c8af08ed4e37a10bbabf98a09a105a5650a8 ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index 68c625258e..c37c4e3444 100644
+index 58257c971e..65ca139be5 100644
@@ -23 +25 @@
-@@ -715,7 +715,7 @@ mana_dev_stats_reset(struct rte_eth_dev *dev __rte_unused)
+@@ -711,7 +711,7 @@ mana_dev_stats_reset(struct rte_eth_dev *dev __rte_unused)


More information about the stable mailing list