patch 'net/ena: fix bad checksum handling' has been queued to stable release 23.11.2
Xueming Li
xuemingl at nvidia.com
Mon Aug 12 14:49:31 CEST 2024
Hi,
FYI, your patch has been queued to stable release 23.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/14/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=db4ca6f1cbd6e5dd9ae133f7609a7538fd5c889c
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From db4ca6f1cbd6e5dd9ae133f7609a7538fd5c889c Mon Sep 17 00:00:00 2001
From: Shai Brandes <shaibran at amazon.com>
Date: Tue, 2 Jul 2024 17:46:22 +0300
Subject: [PATCH] net/ena: fix bad checksum handling
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit fa4bb7025255036fcff9556c637efa2627ac4af4 ]
Removed a workaround for a false L4 bad Rx csum
indication from the device. The workaround was to set it
as unknown so the application would check it instead.
The issue was fixed in the device, thus the driver bad csum
handling should be fixed in the PMD.
Fixes: b2d2f1cf89a6 ("net/ena: fix checksum flag for L4")
Signed-off-by: Shai Brandes <shaibran at amazon.com>
---
drivers/net/ena/ena_ethdev.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index e122a55fa4..676c8cbcc3 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -653,13 +653,7 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring,
} else {
if (unlikely(ena_rx_ctx->l4_csum_err)) {
++rx_stats->l4_csum_bad;
- /*
- * For the L4 Rx checksum offload the HW may indicate
- * bad checksum although it's valid. Because of that,
- * we're setting the UNKNOWN flag to let the app
- * re-verify the checksum.
- */
- ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN;
+ ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;
} else {
++rx_stats->l4_csum_good;
ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-08-12 20:44:05.555819657 +0800
+++ 0094-net-ena-fix-bad-checksum-handling.patch 2024-08-12 20:44:02.365069347 +0800
@@ -1 +1 @@
-From fa4bb7025255036fcff9556c637efa2627ac4af4 Mon Sep 17 00:00:00 2001
+From db4ca6f1cbd6e5dd9ae133f7609a7538fd5c889c Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit fa4bb7025255036fcff9556c637efa2627ac4af4 ]
@@ -13 +15,0 @@
-Cc: stable at dpdk.org
@@ -21 +23 @@
-index 4e7171e629..b43b913903 100644
+index e122a55fa4..676c8cbcc3 100644
@@ -24 +26 @@
-@@ -674,13 +674,7 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring,
+@@ -653,13 +653,7 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring,
More information about the stable
mailing list