patch 'net/gve: fix RSS hash endianness in DQO format' has been queued to stable release 23.11.2

Xueming Li xuemingl at nvidia.com
Mon Aug 12 14:49:34 CEST 2024


Hi,

FYI, your patch has been queued to stable release 23.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/14/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=c90d304f0eed545d8f7ec36ceacf04778c856a7c

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From c90d304f0eed545d8f7ec36ceacf04778c856a7c Mon Sep 17 00:00:00 2001
From: Shreesh Adiga <16567adigashreesh at gmail.com>
Date: Wed, 3 Jul 2024 19:01:53 +0530
Subject: [PATCH] net/gve: fix RSS hash endianness in DQO format
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit b0ab5e931135664a554e0fd1e28fe11ee73f4463 ]

The hash field in struct gve_rx_compl_desc_dqo defined in
gve_desc_dqo.h has the type __le32. Therefore the hash must be
read in little endian rather than big endian.

Bugzilla ID: 1441
Fixes: 45da16b5b181 ("net/gve: support basic Rx data path for DQO")

Signed-off-by: Shreesh Adiga <16567adigashreesh at gmail.com>
Acked-by: Joshua Washington <joshwash at google.com>
---
 .mailmap                     | 1 +
 drivers/net/gve/gve_rx_dqo.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 24c450efaa..38af1e8603 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1319,6 +1319,7 @@ Shiyang He <shiyangx.he at intel.com>
 Shlomi Gridish <sgridish at marvell.com>
 Shougang Wang <shougangx.wang at intel.com>
 Shraddha Joshi <jshraddha at vmware.com>
+Shreesh Adiga <16567adigashreesh at gmail.com>
 Shreyansh Jain <shreyansh.jain at nxp.com>
 Shrikrishna Khare <skhare at vmware.com>
 Shuai Zhu <shuaix.zhu at intel.com>
diff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c
index 7c7a8c48d0..a56cdbf11b 100644
--- a/drivers/net/gve/gve_rx_dqo.c
+++ b/drivers/net/gve/gve_rx_dqo.c
@@ -127,7 +127,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
 		rxm->ol_flags = 0;
 
 		rxm->ol_flags |= RTE_MBUF_F_RX_RSS_HASH;
-		rxm->hash.rss = rte_be_to_cpu_32(rx_desc->hash);
+		rxm->hash.rss = rte_le_to_cpu_32(rx_desc->hash);
 
 		rx_pkts[nb_rx++] = rxm;
 		bytes += pkt_len;
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-08-12 20:44:05.633803551 +0800
+++ 0097-net-gve-fix-RSS-hash-endianness-in-DQO-format.patch	2024-08-12 20:44:02.375069349 +0800
@@ -1 +1 @@
-From b0ab5e931135664a554e0fd1e28fe11ee73f4463 Mon Sep 17 00:00:00 2001
+From c90d304f0eed545d8f7ec36ceacf04778c856a7c Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit b0ab5e931135664a554e0fd1e28fe11ee73f4463 ]
@@ -12 +14,0 @@
-Cc: stable at dpdk.org
@@ -22 +24 @@
-index 874df4d162..9bc25b1521 100644
+index 24c450efaa..38af1e8603 100644
@@ -25 +27 @@
-@@ -1356,6 +1356,7 @@ Shiyang He <shiyangx.he at intel.com>
+@@ -1319,6 +1319,7 @@ Shiyang He <shiyangx.he at intel.com>
@@ -34 +36 @@
-index f08b58c78d..5efcce3312 100644
+index 7c7a8c48d0..a56cdbf11b 100644
@@ -37 +39 @@
-@@ -161,7 +161,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
+@@ -127,7 +127,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
@@ -39,2 +41,2 @@
- 		rxm->ol_flags |= RTE_MBUF_F_RX_RSS_HASH |
- 				gve_parse_csum_ol_flags(rx_desc, rxq->hw);
+ 
+ 		rxm->ol_flags |= RTE_MBUF_F_RX_RSS_HASH;


More information about the stable mailing list