patch 'doc: fix mbuf flags' has been queued to stable release 23.11.2

Xueming Li xuemingl at nvidia.com
Mon Aug 12 14:50:29 CEST 2024
Previous message (by thread): patch 'examples/ipsec-secgw: revert SA salt endianness' has been queued to stable release 23.11.2
Next message (by thread): patch 'doc: add power uncore in API index' has been queued to stable release 23.11.2
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,

FYI, your patch has been queued to stable release 23.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/14/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=09ccd86606e789f163f6106078e6129250f8da86

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 09ccd86606e789f163f6106078e6129250f8da86 Mon Sep 17 00:00:00 2001
From: Yingming Mao <maoyingming at baidu.com>
Date: Thu, 18 Apr 2024 14:20:25 +0800
Subject: [PATCH] doc: fix mbuf flags
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 1d9077d101b5c9ac2f841a82187ef5ced0fc7f43 ]

Fixes: 2542ad53d867 ("doc: add description of the offload API")
Fixes: ae2c2cb60635 ("net/cnxk: avoid command copy from Tx queue")

Signed-off-by: Yingming Mao <maoyingming at baidu.com>
Reviewed-by: Shuo Li <lishuo02 at baidu.com>
---
 .mailmap                           | 3 ++-
 doc/guides/prog_guide/mbuf_lib.rst | 8 ++++----
 drivers/net/cnxk/cn10k_tx.h        | 2 +-
 drivers/net/cnxk/cn9k_tx.h         | 2 +-
 4 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/.mailmap b/.mailmap
index bea129355d..f2883144f3 100644
--- a/.mailmap
+++ b/.mailmap
@@ -868,7 +868,6 @@ Manish Chopra <manishc at marvell.com>
 Manish Kurup <manish.kurup at broadcom.com>
 Manish Tomar <manish.tomar at nxp.com>
 Mao Jiang <maox.jiang at intel.com>
-Mao YingMing <maoyingming at baidu.com>
 Marcel Apfelbaum <marcel at redhat.com>
 Marcel Cornu <marcel.d.cornu at intel.com>
 Marcelo Ricardo Leitner <marcelo.leitner at gmail.com>
@@ -1330,6 +1329,7 @@ Shuki Katzenelson <shuki at lightbitslabs.com>
 Shun Hao <shunh at nvidia.com>
 Shu Shen <shu.shen at radisys.com>
 Shujing Dong <shujing.dong at corigine.com>
+Shuo Li <lishuo02 at baidu.com>
 Shweta Choudaha <shweta.choudaha at att.com>
 Shyam Kumar Shrivastav <shrivastav.shyam at gmail.com>
 Shy Shyman <shys at nvidia.com> <shys at mellanox.com>
@@ -1635,6 +1635,7 @@ Yi Lu <luyi68 at live.com>
 Yilun Xu <yilun.xu at intel.com>
 Yinan Wang <yinan.wang at intel.com>
 Ying A Wang <ying.a.wang at intel.com>
+Yingming Mao <maoyingming at baidu.com>
 Yingya Han <yingyax.han at intel.com>
 Yinjun Zhang <yinjun.zhang at corigine.com>
 Yipeng Wang <yipeng1.wang at intel.com>
diff --git a/doc/guides/prog_guide/mbuf_lib.rst b/doc/guides/prog_guide/mbuf_lib.rst
index 049357c755..749f9c97a8 100644
--- a/doc/guides/prog_guide/mbuf_lib.rst
+++ b/doc/guides/prog_guide/mbuf_lib.rst
@@ -134,7 +134,7 @@ a vxlan-encapsulated tcp packet:
 
     mb->l2_len = len(out_eth)
     mb->l3_len = len(out_ip)
-    mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CSUM
+    mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CKSUM
     set out_ip checksum to 0 in the packet
 
   This is supported on hardware advertising RTE_ETH_TX_OFFLOAD_IPV4_CKSUM.
@@ -143,7 +143,7 @@ a vxlan-encapsulated tcp packet:
 
     mb->l2_len = len(out_eth)
     mb->l3_len = len(out_ip)
-    mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CSUM | RTE_MBUF_F_TX_UDP_CKSUM
+    mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CKSUM | RTE_MBUF_F_TX_UDP_CKSUM
     set out_ip checksum to 0 in the packet
     set out_udp checksum to pseudo header using rte_ipv4_phdr_cksum()
 
@@ -154,7 +154,7 @@ a vxlan-encapsulated tcp packet:
 
     mb->l2_len = len(out_eth + out_ip + out_udp + vxlan + in_eth)
     mb->l3_len = len(in_ip)
-    mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CSUM
+    mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CKSUM
     set in_ip checksum to 0 in the packet
 
   This is similar to case 1), but l2_len is different. It is supported
@@ -165,7 +165,7 @@ a vxlan-encapsulated tcp packet:
 
     mb->l2_len = len(out_eth + out_ip + out_udp + vxlan + in_eth)
     mb->l3_len = len(in_ip)
-    mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CSUM | RTE_MBUF_F_TX_TCP_CKSUM
+    mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CKSUM | RTE_MBUF_F_TX_TCP_CKSUM
     set in_ip checksum to 0 in the packet
     set in_tcp checksum to pseudo header using rte_ipv4_phdr_cksum()
 
diff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h
index 0a2ad08f1f..c84154ee84 100644
--- a/drivers/net/cnxk/cn10k_tx.h
+++ b/drivers/net/cnxk/cn10k_tx.h
@@ -1293,7 +1293,7 @@ cn10k_nix_xmit_prepare_tstamp(struct cn10k_eth_txq *txq, uintptr_t lmt_addr,
 		struct nix_send_mem_s *send_mem;
 
 		send_mem = (struct nix_send_mem_s *)(lmt + off);
-		/* Packets for which PKT_TX_IEEE1588_TMST is not set, tx tstamp
+		/* Packets for which RTE_MBUF_F_TX_IEEE1588_TMST is not set, Tx tstamp
 		 * should not be recorded, hence changing the alg type to
 		 * NIX_SENDMEMALG_SUB and also changing send mem addr field to
 		 * next 8 bytes as it corrupts the actual Tx tstamp registered
diff --git a/drivers/net/cnxk/cn9k_tx.h b/drivers/net/cnxk/cn9k_tx.h
index 636eb1f765..4715bf8a65 100644
--- a/drivers/net/cnxk/cn9k_tx.h
+++ b/drivers/net/cnxk/cn9k_tx.h
@@ -560,7 +560,7 @@ cn9k_nix_xmit_prepare_tstamp(struct cn9k_eth_txq *txq, uint64_t *cmd,
 
 		send_mem = (struct nix_send_mem_s *)(cmd + off);
 
-		/* Packets for which PKT_TX_IEEE1588_TMST is not set, tx tstamp
+		/* Packets for which RTE_MBUF_F_TX_IEEE1588_TMST is not set, Tx tstamp
 		 * should not be recorded, hence changing the alg type to
 		 * NIX_SENDMEMALG_SUB and also changing send mem addr field to
 		 * next 8 bytes as it corrupts the actual Tx tstamp registered
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-08-12 20:44:07.285982420 +0800
+++ 0152-doc-fix-mbuf-flags.patch	2024-08-12 20:44:02.595069393 +0800
@@ -1 +1 @@
-From 1d9077d101b5c9ac2f841a82187ef5ced0fc7f43 Mon Sep 17 00:00:00 2001
+From 09ccd86606e789f163f6106078e6129250f8da86 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 1d9077d101b5c9ac2f841a82187ef5ced0fc7f43 ]
@@ -8 +10,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index 8aef1c59a4..4a508bafad 100644
+index bea129355d..f2883144f3 100644
@@ -23 +25 @@
-@@ -893,7 +893,6 @@ Manish Chopra <manishc at marvell.com>
+@@ -868,7 +868,6 @@ Manish Chopra <manishc at marvell.com>
@@ -31 +33 @@
-@@ -1371,6 +1370,7 @@ Shuki Katzenelson <shuki at lightbitslabs.com>
+@@ -1330,6 +1329,7 @@ Shuki Katzenelson <shuki at lightbitslabs.com>
@@ -39 +41 @@
-@@ -1684,6 +1684,7 @@ Yi Lu <luyi68 at live.com>
+@@ -1635,6 +1635,7 @@ Yi Lu <luyi68 at live.com>
@@ -88 +90 @@
-index 84b08403c0..7d9b259a5f 100644
+index 0a2ad08f1f..c84154ee84 100644
@@ -91 +93 @@
-@@ -1242,7 +1242,7 @@ cn10k_nix_xmit_prepare_tstamp(struct cn10k_eth_txq *txq, uintptr_t lmt_addr,
+@@ -1293,7 +1293,7 @@ cn10k_nix_xmit_prepare_tstamp(struct cn10k_eth_txq *txq, uintptr_t lmt_addr,
@@ -101 +103 @@
-index b56881c561..9370985864 100644
+index 636eb1f765..4715bf8a65 100644
Previous message (by thread): patch 'examples/ipsec-secgw: revert SA salt endianness' has been queued to stable release 23.11.2
Next message (by thread): patch 'doc: add power uncore in API index' has been queued to stable release 23.11.2
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the stable mailing list