patch 'net/ixgbe: fix link status delay on FreeBSD' has been queued to stable release 23.11.3
Xueming Li
xuemingl at nvidia.com
Sat Dec 7 08:59:23 CET 2024
Hi,
FYI, your patch has been queued to stable release 23.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/10/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=d30bef9034c7ebb54096d40326bcab0ed78e92d3
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From d30bef9034c7ebb54096d40326bcab0ed78e92d3 Mon Sep 17 00:00:00 2001
From: Lewis Donzis <lew at perftech.com>
Date: Tue, 22 Oct 2024 09:42:05 -0500
Subject: [PATCH] net/ixgbe: fix link status delay on FreeBSD
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit f775386d92d68e534600fcff3fc4bcaa30d3e68c ]
Forcing wait true prevents checking link status without delay, because
the function will wait more than 10 seconds for link status to be true,
even if the API caller requested no waiting.
Fixes: 0012111a3d87 ("net/ixgbe: fix link status synchronization on BSD")
Signed-off-by: Lewis Donzis <lew at perftech.com>
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 3ac65ca3b3..f4ec485d69 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4305,11 +4305,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0)
wait = 0;
-/* BSD has no interrupt mechanism, so force NIC status synchronization. */
-#ifdef RTE_EXEC_ENV_FREEBSD
- wait = 1;
-#endif
-
if (vf)
diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);
else
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-12-06 23:26:44.310023424 +0800
+++ 0005-net-ixgbe-fix-link-status-delay-on-FreeBSD.patch 2024-12-06 23:26:43.843044829 +0800
@@ -1 +1 @@
-From f775386d92d68e534600fcff3fc4bcaa30d3e68c Mon Sep 17 00:00:00 2001
+From d30bef9034c7ebb54096d40326bcab0ed78e92d3 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit f775386d92d68e534600fcff3fc4bcaa30d3e68c ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index ab37c37469..008760e315 100644
+index 3ac65ca3b3..f4ec485d69 100644
@@ -23 +25 @@
-@@ -4314,11 +4314,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
+@@ -4305,11 +4305,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
More information about the stable
mailing list