patch 'test/crypto: fix synchronous API calls' has been queued to stable release 23.11.3

Xueming Li xuemingl at nvidia.com
Sat Dec 7 09:00:04 CET 2024


Hi,

FYI, your patch has been queued to stable release 23.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/10/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=11b2730b1dd2f587e485cc390535421ec2844d7a

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 11b2730b1dd2f587e485cc390535421ec2844d7a Mon Sep 17 00:00:00 2001
From: Brian Dooley <brian.dooley at intel.com>
Date: Fri, 25 Oct 2024 15:22:51 +0100
Subject: [PATCH] test/crypto: fix synchronous API calls
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 251fdc592da5eddc4d84a95d0c151b0134504a32 ]

For the synchronous API the enqueue/dequeue burst functions are not
called. Skip these tests when calling the synchronous API.

Fixes: 4ad17a1c8fb3 ("test/crypto: fix enqueue/dequeue callback case")

Signed-off-by: Brian Dooley <brian.dooley at intel.com>
---
 app/test/test_cryptodev.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 6cd38aefae..7d9fe29c02 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -13625,6 +13625,10 @@ test_enq_callback_setup(void)
 	uint16_t qp_id = 0;
 	int j = 0;

+	/* Skip test if synchronous API is used */
+	if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO)
+		return TEST_SKIPPED;
+
 	/* Verify the crypto capabilities for which enqueue/dequeue is done. */
 	cap_idx.type = RTE_CRYPTO_SYM_XFORM_AUTH;
 	cap_idx.algo.auth = RTE_CRYPTO_AUTH_NULL;
@@ -13746,6 +13750,10 @@ test_deq_callback_setup(void)
 	uint16_t qp_id = 0;
 	int j = 0;

+	/* Skip test if synchronous API is used */
+	if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO)
+		return TEST_SKIPPED;
+
 	/* Verify the crypto capabilities for which enqueue/dequeue is done. */
 	cap_idx.type = RTE_CRYPTO_SYM_XFORM_AUTH;
 	cap_idx.algo.auth = RTE_CRYPTO_AUTH_NULL;
--
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-12-06 23:26:45.630271209 +0800
+++ 0046-test-crypto-fix-synchronous-API-calls.patch	2024-12-06 23:26:43.953044828 +0800
@@ -1 +1 @@
-From 251fdc592da5eddc4d84a95d0c151b0134504a32 Mon Sep 17 00:00:00 2001
+From 11b2730b1dd2f587e485cc390535421ec2844d7a Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 251fdc592da5eddc4d84a95d0c151b0134504a32 ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
@@ -14,2 +16,2 @@
- app/test/test_cryptodev.c | 11 ++++++++++-
- 1 file changed, 10 insertions(+), 1 deletion(-)
+ app/test/test_cryptodev.c | 8 ++++++++
+ 1 file changed, 8 insertions(+)
@@ -18 +20 @@
-index 25eef342b0..c647baeee1 100644
+index 6cd38aefae..7d9fe29c02 100644
@@ -21,11 +23 @@
-@@ -2496,7 +2496,8 @@ test_queue_pair_descriptor_count(void)
- 	int qp_depth = 0;
- 	int i;
-
--	RTE_VERIFY(gbl_action_type != RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO);
-+	if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO)
-+		return TEST_SKIPPED;
-
- 	/* Verify if the queue pair depth API is supported by driver */
- 	qp_depth = rte_cryptodev_qp_depth_used(ts_params->valid_devs[0], 0);
-@@ -15135,6 +15136,10 @@ test_enq_callback_setup(void)
+@@ -13625,6 +13625,10 @@ test_enq_callback_setup(void)
@@ -42 +34 @@
-@@ -15256,6 +15261,10 @@ test_deq_callback_setup(void)
+@@ -13746,6 +13750,10 @@ test_deq_callback_setup(void)


More information about the stable mailing list