patch 'common/dpaax/caamflib: enable fallthrough warnings' has been queued to stable release 23.11.3
Xueming Li
xuemingl at nvidia.com
Sat Dec 7 09:00:37 CET 2024
Hi,
FYI, your patch has been queued to stable release 23.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/10/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=a6c7a5855c7bbe729aebfb297bc0bd99ab7421a2
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From a6c7a5855c7bbe729aebfb297bc0bd99ab7421a2 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Thu, 14 Nov 2024 09:11:54 -0800
Subject: [PATCH] common/dpaax/caamflib: enable fallthrough warnings
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 277552e175b3529863adec9bbd8bb6288164506e ]
Fallthrough warnings catch real bugs and should not be disabled.
There are warnings in this driver in current build.
The commit that added the disable is old, and the problematic code
appears to have been already removed.
Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
---
drivers/common/dpaax/caamflib/rta/operation_cmd.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/common/dpaax/caamflib/rta/operation_cmd.h b/drivers/common/dpaax/caamflib/rta/operation_cmd.h
index fe1ac37ee8..563735eb88 100644
--- a/drivers/common/dpaax/caamflib/rta/operation_cmd.h
+++ b/drivers/common/dpaax/caamflib/rta/operation_cmd.h
@@ -7,10 +7,6 @@
#ifndef __RTA_OPERATION_CMD_H__
#define __RTA_OPERATION_CMD_H__
-#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 70000)
-#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
-#endif
-
extern enum rta_sec_era rta_sec_era;
static inline int
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-12-06 23:26:46.741908603 +0800
+++ 0079-common-dpaax-caamflib-enable-fallthrough-warnings.patch 2024-12-06 23:26:44.083044826 +0800
@@ -1 +1 @@
-From 277552e175b3529863adec9bbd8bb6288164506e Mon Sep 17 00:00:00 2001
+From a6c7a5855c7bbe729aebfb297bc0bd99ab7421a2 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 277552e175b3529863adec9bbd8bb6288164506e ]
@@ -13 +15,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list