patch 'app/procinfo: fix leak on exit' has been queued to stable release 23.11.3
Xueming Li
xuemingl at nvidia.com
Sat Dec 7 09:00:39 CET 2024
Hi,
FYI, your patch has been queued to stable release 23.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/10/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=8dffe1833feaac46a3a4c48c2b8469a2e2007cb7
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 8dffe1833feaac46a3a4c48c2b8469a2e2007cb7 Mon Sep 17 00:00:00 2001
From: Fidaullah Noonari <fidaullah.noonari at emumba.com>
Date: Thu, 3 Oct 2024 19:48:29 -0700
Subject: [PATCH] app/procinfo: fix leak on exit
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 8a171e52ed8b26f768ced79a22286914ebd30180 ]
When app is launched with -m proc-info exit without
rte_eal_cleanup() causing memory leakage. This commit resolves the
memory leakage issue and closes app properly.
Bugzilla ID: 898
Fixes: 67684d1e87b6 ("app/procinfo: call EAL cleanup before exit")
Fixes: 674bb3906931 ("app/procinfo: display eventdev xstats")
Signed-off-by: Fidaullah Noonari <fidaullah.noonari at emumba.com>
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Chengwen Feng <fengchengwen at huawei.com>
---
app/proc-info/main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index b672aaefbe..4a558705cc 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -2166,11 +2166,11 @@ main(int argc, char **argv)
if (mem_info) {
meminfo_display();
- return 0;
+ goto cleanup;
}
if (eventdev_xstats() > 0)
- return 0;
+ goto cleanup;
nb_ports = rte_eth_dev_count_avail();
if (nb_ports == 0)
@@ -2251,6 +2251,7 @@ main(int argc, char **argv)
RTE_ETH_FOREACH_DEV(i)
rte_eth_dev_close(i);
+cleanup:
ret = rte_eal_cleanup();
if (ret)
printf("Error from rte_eal_cleanup(), %d\n", ret);
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-12-06 23:26:46.802334304 +0800
+++ 0081-app-procinfo-fix-leak-on-exit.patch 2024-12-06 23:26:44.083044826 +0800
@@ -1 +1 @@
-From 8a171e52ed8b26f768ced79a22286914ebd30180 Mon Sep 17 00:00:00 2001
+From 8dffe1833feaac46a3a4c48c2b8469a2e2007cb7 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 8a171e52ed8b26f768ced79a22286914ebd30180 ]
@@ -13 +15,0 @@
-Cc: stable at dpdk.org
@@ -23 +25 @@
-index 6886eb373a..e1272164b1 100644
+index b672aaefbe..4a558705cc 100644
@@ -26 +28 @@
-@@ -2171,11 +2171,11 @@ main(int argc, char **argv)
+@@ -2166,11 +2166,11 @@ main(int argc, char **argv)
@@ -40 +42 @@
-@@ -2256,6 +2256,7 @@ main(int argc, char **argv)
+@@ -2251,6 +2251,7 @@ main(int argc, char **argv)
More information about the stable
mailing list