[PATCH 1/1] common/sfc_efx/base: remove unreachable code

Ariel Otilibili otilibil at eurecom.fr
Sat Dec 21 14:27:07 CET 2024


The default switch case ends with a goto; meaning these instructions are
never reached.

Coverity issue: 121742
Fixes: 19b64c6ac3 ("net/sfc/base: import libefx base")
Signed-off-by: Ariel Otilibili <otilibil at eurecom.fr>
--
Cc: stable at dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
---
 drivers/common/sfc_efx/base/efx_mon.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/common/sfc_efx/base/efx_mon.c b/drivers/common/sfc_efx/base/efx_mon.c
index ee449ef5eb..5706171abd 100644
--- a/drivers/common/sfc_efx/base/efx_mon.c
+++ b/drivers/common/sfc_efx/base/efx_mon.c
@@ -80,9 +80,6 @@ efx_mon_init(
 		goto fail2;
 	}
 
-	emp->em_emop = emop;
-	return (0);
-
 fail2:
 	EFSYS_PROBE(fail2);
 
-- 
2.47.1



More information about the stable mailing list