patch 'net/vmxnet3: add missing register command' has been queued to stable release 23.11.2
Xueming Li
xuemingl at nvidia.com
Fri Jul 12 12:44:05 CEST 2024
Hi,
FYI, your patch has been queued to stable release 23.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/14/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=57d6e27ef584849a3759a26b9b9c891437ebdbda
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 57d6e27ef584849a3759a26b9b9c891437ebdbda Mon Sep 17 00:00:00 2001
From: Ronak Doshi <ronak.doshi at broadcom.com>
Date: Mon, 22 Apr 2024 11:10:50 -0700
Subject: [PATCH] net/vmxnet3: add missing register command
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 5296276e4b86db7d3a77ac5788d15fbc8406d501 ]
vmxnet3 uses capability registers to advertise the supported
capabilities of UPT device. It uses DCR0_REG command register for this
purpose.
However, the register command enum misses one command which technically
is not used by dpdk vmxnet3 driver yet.
This can cause issue for commands added later.
For example, DCR0_REG and MAX_CAPABILITIES register commands when issued
will lead to incorrect command being executed in the hypervisor. The
return values can be unexpected and can result in some capabilities
being disabled and affect vnics requesting Uniform Passthroguh (UPT)
mode.
This patch fixes this issue by adding a reserved command in its place.
Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers")
Signed-off-by: Ronak Doshi <ronak.doshi at broadcom.com>
Acked-by: Ferruh Yigit <ferruh.yigit at amd.com>
---
.mailmap | 2 +-
drivers/net/vmxnet3/base/vmxnet3_defs.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/.mailmap b/.mailmap
index c6bf385a59..db6bc47117 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1216,7 +1216,7 @@ Roman Kapl <rka at sysgo.com>
Roman Korynkevych <romanx.korynkevych at intel.com>
Roman Storozhenko <roman.storozhenko at intel.com>
Roman Zhukov <roman.zhukov at arknetworks.am> <roman.zhukov at oktetlabs.ru>
-Ronak Doshi <doshir at vmware.com>
+Ronak Doshi <ronak.doshi at broadcom.com> <doshir at vmware.com>
Ron Beider <rbeider at amazon.com>
Ronghua Zhang <rzhang at vmware.com>
RongQiang Xie <xie.rongqiang at zte.com.cn>
diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h
index 24c235876e..a6bb281d8d 100644
--- a/drivers/net/vmxnet3/base/vmxnet3_defs.h
+++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h
@@ -126,6 +126,7 @@ typedef enum {
VMXNET3_CMD_RESERVED7,
VMXNET3_CMD_RESERVED8,
VMXNET3_CMD_GET_MAX_QUEUES_CONF,
+ VMXNET3_CMD_RESERVED11,
VMXNET3_CMD_GET_MAX_CAPABILITIES,
VMXNET3_CMD_GET_DCR0_REG,
} Vmxnet3_Cmd;
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-07-12 18:40:15.167873900 +0800
+++ 0019-net-vmxnet3-add-missing-register-command.patch 2024-07-12 18:40:13.966594244 +0800
@@ -1 +1 @@
-From 5296276e4b86db7d3a77ac5788d15fbc8406d501 Mon Sep 17 00:00:00 2001
+From 57d6e27ef584849a3759a26b9b9c891437ebdbda Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 5296276e4b86db7d3a77ac5788d15fbc8406d501 ]
@@ -22 +24,0 @@
-Cc: stable at dpdk.org
@@ -32 +34 @@
-index de326949c4..cb8d65bf0e 100644
+index c6bf385a59..db6bc47117 100644
@@ -35 +37 @@
-@@ -1229,7 +1229,7 @@ Roman Kapl <rka at sysgo.com>
+@@ -1216,7 +1216,7 @@ Roman Kapl <rka at sysgo.com>
More information about the stable
mailing list