patch 'net/tap: fix file descriptor check in isolated flow' has been queued to stable release 23.11.2
Xueming Li
xuemingl at nvidia.com
Fri Jul 12 12:44:14 CEST 2024
Hi,
FYI, your patch has been queued to stable release 23.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/14/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=92d455764ca76de41a9d148838c6eb2eb1bd6579
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 92d455764ca76de41a9d148838c6eb2eb1bd6579 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Tue, 21 May 2024 13:12:46 -0700
Subject: [PATCH] net/tap: fix file descriptor check in isolated flow
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit e9e6089a41c275f3dcd7491f4df903a284653bb9 ]
The check for receive queue FD in flow_isolate is incorrect.
If queue has not been setup then FD will be -1 not 0.
Fixes: f503d2694825 ("net/tap: support flow API isolated mode")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Ferruh Yigit <ferruh.yigit at amd.com>
---
drivers/net/tap/tap_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c
index fa50fe45d7..79cd6a12ca 100644
--- a/drivers/net/tap/tap_flow.c
+++ b/drivers/net/tap/tap_flow.c
@@ -1595,7 +1595,7 @@ tap_flow_isolate(struct rte_eth_dev *dev,
* If netdevice is there, setup appropriate flow rules immediately.
* Otherwise it will be set when bringing up the netdevice (tun_alloc).
*/
- if (!process_private->rxq_fds[0])
+ if (process_private->rxq_fds[0] == -1)
return 0;
if (set) {
struct rte_flow *remote_flow;
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-07-12 18:40:15.500910360 +0800
+++ 0028-net-tap-fix-file-descriptor-check-in-isolated-flow.patch 2024-07-12 18:40:13.986594241 +0800
@@ -1 +1 @@
-From e9e6089a41c275f3dcd7491f4df903a284653bb9 Mon Sep 17 00:00:00 2001
+From 92d455764ca76de41a9d148838c6eb2eb1bd6579 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit e9e6089a41c275f3dcd7491f4df903a284653bb9 ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list