patch 'baseband/acc: fix memory barrier' has been queued to stable release 23.11.2
Xueming Li
xuemingl at nvidia.com
Fri Jul 12 12:44:43 CEST 2024
Hi,
FYI, your patch has been queued to stable release 23.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/14/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=0ab5bf3a37e66ef3a049a53c27865282a39c8d3c
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 0ab5bf3a37e66ef3a049a53c27865282a39c8d3c Mon Sep 17 00:00:00 2001
From: Hernan Vargas <hernan.vargas at intel.com>
Date: Thu, 2 May 2024 13:45:44 -0700
Subject: [PATCH] baseband/acc: fix memory barrier
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 0a200a3a29017f6b01a481776a571a75e03a32ce ]
Moving memory barrier so that dequeue thread can be in sync with enqueue
thread.
Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code")
Signed-off-by: Hernan Vargas <hernan.vargas at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
drivers/baseband/acc/acc_common.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h
index bda2ad2f7a..6752c256d2 100644
--- a/drivers/baseband/acc/acc_common.h
+++ b/drivers/baseband/acc/acc_common.h
@@ -1110,6 +1110,9 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,
req_elem_addr,
(void *)q->mmio_reg_enqueue);
+ q->aq_enqueued++;
+ q->sw_ring_head += enq_batch_size;
+
rte_wmb();
/* Start time measurement for enqueue function offload. */
@@ -1120,8 +1123,6 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,
queue_stats->acc_offload_cycles += rte_rdtsc_precise() - start_time;
- q->aq_enqueued++;
- q->sw_ring_head += enq_batch_size;
n -= enq_batch_size;
} while (n);
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-07-12 18:40:16.798500604 +0800
+++ 0057-baseband-acc-fix-memory-barrier.patch 2024-07-12 18:40:14.116594226 +0800
@@ -1 +1 @@
-From 0a200a3a29017f6b01a481776a571a75e03a32ce Mon Sep 17 00:00:00 2001
+From 0ab5bf3a37e66ef3a049a53c27865282a39c8d3c Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 0a200a3a29017f6b01a481776a571a75e03a32ce ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
@@ -19 +21 @@
-index fddeb0737b..e249f37e38 100644
+index bda2ad2f7a..6752c256d2 100644
@@ -22 +24 @@
-@@ -1112,6 +1112,9 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,
+@@ -1110,6 +1110,9 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,
@@ -32 +34 @@
-@@ -1122,8 +1125,6 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,
+@@ -1120,8 +1123,6 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,
More information about the stable
mailing list