patch 'net/mlx5/hws: decrease log level for creation failure' has been queued to stable release 23.11.2
Xueming Li
xuemingl at nvidia.com
Fri Jul 12 13:01:32 CEST 2024
Hi,
FYI, your patch has been queued to stable release 23.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/14/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=6a05d2e85bb2aec3c2ecabfed226c06f6777f292
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 6a05d2e85bb2aec3c2ecabfed226c06f6777f292 Mon Sep 17 00:00:00 2001
From: Erez Shitrit <erezsh at nvidia.com>
Date: Mon, 6 May 2024 14:44:04 +0300
Subject: [PATCH] net/mlx5/hws: decrease log level for creation failure
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit e014d5e2e49994fbc504a49814ed480a60c85d63 ]
When the user tries to create a matcher and if failed with specific
errno (E2BIG) the message will be in debug level and not in warning.
It is a part of a feature when the user re-try to insert a new matching
depends on that errno, no need the annoying message.
Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer")
Signed-off-by: Erez Shitrit <erezsh at nvidia.com>
Acked-by: Matan Azrad <matan at nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_definer.c | 6 +++---
drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c
index 3391b3d32a..003b50623c 100644
--- a/drivers/net/mlx5/hws/mlx5dr_definer.c
+++ b/drivers/net/mlx5/hws/mlx5dr_definer.c
@@ -2857,7 +2857,7 @@ mlx5dr_definer_find_best_match_fit(struct mlx5dr_context *ctx,
return 0;
}
- DR_LOG(ERR, "Unable to find supporting match/jumbo definer combination");
+ DR_LOG(DEBUG, "Unable to find supporting match/jumbo definer combination");
rte_errno = ENOTSUP;
return rte_errno;
}
@@ -2990,7 +2990,7 @@ mlx5dr_definer_calc_layout(struct mlx5dr_matcher *matcher,
/* Find the match definer layout for header layout match union */
ret = mlx5dr_definer_find_best_match_fit(ctx, match_definer, match_hl);
if (ret) {
- DR_LOG(ERR, "Failed to create match definer from header layout");
+ DR_LOG(DEBUG, "Failed to create match definer from header layout");
goto free_fc;
}
@@ -3335,7 +3335,7 @@ int mlx5dr_definer_matcher_init(struct mlx5dr_context *ctx,
ret = mlx5dr_definer_calc_layout(matcher, &match_layout, &range_layout);
if (ret) {
- DR_LOG(ERR, "Failed to calculate matcher definer layout");
+ DR_LOG(DEBUG, "Failed to calculate matcher definer layout");
return ret;
}
diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c
index 71478dab33..bb171a0340 100644
--- a/drivers/net/mlx5/hws/mlx5dr_matcher.c
+++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c
@@ -807,7 +807,7 @@ static int mlx5dr_matcher_bind_mt(struct mlx5dr_matcher *matcher)
/* Calculate match, range and hash definers */
ret = mlx5dr_definer_matcher_init(ctx, matcher);
if (ret) {
- DR_LOG(ERR, "Failed to set matcher templates with match definers");
+ DR_LOG(DEBUG, "Failed to set matcher templates with match definers");
return ret;
}
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-07-12 18:40:17.758687288 +0800
+++ 0081-net-mlx5-hws-decrease-log-level-for-creation-failure.patch 2024-07-12 18:40:14.226594213 +0800
@@ -1 +1 @@
-From e014d5e2e49994fbc504a49814ed480a60c85d63 Mon Sep 17 00:00:00 2001
+From 6a05d2e85bb2aec3c2ecabfed226c06f6777f292 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit e014d5e2e49994fbc504a49814ed480a60c85d63 ]
@@ -12 +14,0 @@
-Cc: stable at dpdk.org
@@ -22 +24 @@
-index a0f95c6923..88be27dcbb 100644
+index 3391b3d32a..003b50623c 100644
@@ -25 +27 @@
-@@ -3539,7 +3539,7 @@ mlx5dr_definer_find_best_match_fit(struct mlx5dr_context *ctx,
+@@ -2857,7 +2857,7 @@ mlx5dr_definer_find_best_match_fit(struct mlx5dr_context *ctx,
@@ -31 +33 @@
- rte_errno = E2BIG;
+ rte_errno = ENOTSUP;
@@ -34 +36 @@
-@@ -3694,7 +3694,7 @@ mlx5dr_definer_calc_layout(struct mlx5dr_matcher *matcher,
+@@ -2990,7 +2990,7 @@ mlx5dr_definer_calc_layout(struct mlx5dr_matcher *matcher,
@@ -43 +45 @@
-@@ -4046,7 +4046,7 @@ int mlx5dr_definer_matcher_init(struct mlx5dr_context *ctx,
+@@ -3335,7 +3335,7 @@ int mlx5dr_definer_matcher_init(struct mlx5dr_context *ctx,
@@ -53 +55 @@
-index aeff300467..c9f5e46d24 100644
+index 71478dab33..bb171a0340 100644
@@ -56 +58 @@
-@@ -877,7 +877,7 @@ static int mlx5dr_matcher_bind_mt(struct mlx5dr_matcher *matcher)
+@@ -807,7 +807,7 @@ static int mlx5dr_matcher_bind_mt(struct mlx5dr_matcher *matcher)
More information about the stable
mailing list