[PATCH 23.11] net/nfp: fix port ID meta data use in Rx

[Chaoyong He]

Hi Xueming,

After checking the logic carefully, we found this patch need not backport, because this bug is imported by another patch series which is not exist in DPDK 23.11 release version.

Really sorry about this.

From: Xueming Li <xuemingl at nvidia.com>
Sent: Wednesday, May 1, 2024 9:51 AM
To: Chaoyong He <chaoyong.he at corigine.com>; stable at dpdk.org
Cc: oss-drivers <oss-drivers at corigine.com>; Long Wu <Long.Wu at nephogine.com>; Nole Zhang <peng.zhang at corigine.com>
Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx

Some people who received this message don't often get email from xuemingl at nvidia.com<mailto:xuemingl at nvidia.com>. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
I got following compilation error:
  ../../auto/swgwork/xuemingl/workspace/dpdk/drivers/net/nfp/nfp_rxtx.c:763:14: error: no member named 'flags' in 'struct nfp_meta_parsed'
Could you please address ASAP? make sure it tested.

Thanks,
________________________________
From: Xueming Li <xuemingl at nvidia.com<mailto:xuemingl at nvidia.com>>
Sent: Wednesday, May 1, 2024 9:19 AM
To: Chaoyong He <chaoyong.he at corigine.com<mailto:chaoyong.he at corigine.com>>; stable at dpdk.org<mailto:stable at dpdk.org> <stable at dpdk.org<mailto:stable at dpdk.org>>
Cc: oss-drivers at corigine.com<mailto:oss-drivers at corigine.com> <oss-drivers at corigine.com<mailto:oss-drivers at corigine.com>>; Long Wu <long.wu at corigine.com<mailto:long.wu at corigine.com>>; Peng Zhang <peng.zhang at corigine.com<mailto:peng.zhang at corigine.com>>
Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx

Hi Chaoyong,

Thanks for your help, patch added into release queue.
________________________________
From: Chaoyong He <chaoyong.he at corigine.com<mailto:chaoyong.he at corigine.com>>
Sent: Monday, April 15, 2024 10:40 AM
To: stable at dpdk.org<mailto:stable at dpdk.org> <stable at dpdk.org<mailto:stable at dpdk.org>>
Cc: oss-drivers at corigine.com<mailto:oss-drivers at corigine.com> <oss-drivers at corigine.com<mailto:oss-drivers at corigine.com>>; Long Wu <long.wu at corigine.com<mailto:long.wu at corigine.com>>; Chaoyong He <chaoyong.he at corigine.com<mailto:chaoyong.he at corigine.com>>; Peng Zhang <peng.zhang at corigine.com<mailto:peng.zhang at corigine.com>>
Subject: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx

From: Long Wu <long.wu at corigine.com<mailto:long.wu at corigine.com>>

[ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ]

Meta data parsing should be controlled by meta data flag. So use
flag to determine if receive function can use 'port_id' meta data.

Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor")

Signed-off-by: Long Wu <long.wu at corigine.com<mailto:long.wu at corigine.com>>
Reviewed-by: Chaoyong He <chaoyong.he at corigine.com<mailto:chaoyong.he at corigine.com>>
Reviewed-by: Peng Zhang <peng.zhang at corigine.com<mailto:peng.zhang at corigine.com>>
---
 drivers/net/nfp/nfp_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c
index 8ca651ba55..5033d659d3 100644
--- a/drivers/net/nfp/nfp_rxtx.c
+++ b/drivers/net/nfp/nfp_rxtx.c
@@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue,
                 if (unlikely(rxq->rd_p == rxq->rx_count)) /* Wrapping */
                         rxq->rd_p = 0;

-               if (meta.port_id == 0) {
+               if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) == 0) {
                         rx_pkts[avail++] = mb;
                 } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_id)) {
                         avail_multiplexed++;
--
2.27.0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/stable/attachments/20240507/8f642b8f/attachment.htm>