[PATCH] app/dumpcap: remove unused struct array

Bruce Richardson bruce.richardson at intel.com
Tue Nov 5 12:27:21 CET 2024


The callbacks(rx_cb) member of struct interface was unused inside
dumpcap, but was taking up a lot of memory space, since it was scaled
according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save
memory by removing the whole array.

Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Cc: stable at dpdk.org

Suggested-by: Stephen Hemminger <stephen at networkplumber.org>
Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
---
 app/dumpcap/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index 4031f48441..3d3c0dbc66 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -96,7 +96,6 @@ struct interface {
 	struct rte_bpf_prm *bpf_prm;
 	char name[RTE_ETH_NAME_MAX_LEN];
 
-	struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT];
 	const char *ifname;
 	const char *ifdescr;
 };
-- 
2.43.0



More information about the stable mailing list