patch 'app/testpmd: remove flex item init command leftover' has been queued to stable release 23.11.3
Xueming Li
xuemingl at nvidia.com
Mon Nov 11 07:28:35 CET 2024
Hi,
FYI, your patch has been queued to stable release 23.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/30/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=179f82ff012e353903bad9c9b0451b09c6941600
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 179f82ff012e353903bad9c9b0451b09c6941600 Mon Sep 17 00:00:00 2001
From: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
Date: Wed, 18 Sep 2024 16:46:20 +0300
Subject: [PATCH] app/testpmd: remove flex item init command leftover
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit d5c50397a1cc06419970afbea9cd1c37e3c08a5b ]
There was a leftover of "flow flex init" command used
for debug purposes and had no useful functionality in
the production code.
Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
Acked-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
---
app/test-pmd/cmdline_flow.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 7e6e06a04f..4b13d84ad1 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -105,7 +105,6 @@ enum index {
HASH,
/* Flex arguments */
- FLEX_ITEM_INIT,
FLEX_ITEM_CREATE,
FLEX_ITEM_DESTROY,
@@ -1249,7 +1248,6 @@ struct parse_action_priv {
})
static const enum index next_flex_item[] = {
- FLEX_ITEM_INIT,
FLEX_ITEM_CREATE,
FLEX_ITEM_DESTROY,
ZERO,
@@ -3932,15 +3930,6 @@ static const struct token token_list[] = {
.next = NEXT(next_flex_item),
.call = parse_flex,
},
- [FLEX_ITEM_INIT] = {
- .name = "init",
- .help = "flex item init",
- .args = ARGS(ARGS_ENTRY(struct buffer, args.flex.token),
- ARGS_ENTRY(struct buffer, port)),
- .next = NEXT(NEXT_ENTRY(COMMON_FLEX_TOKEN),
- NEXT_ENTRY(COMMON_PORT_ID)),
- .call = parse_flex
- },
[FLEX_ITEM_CREATE] = {
.name = "create",
.help = "flex item create",
@@ -10720,7 +10709,6 @@ parse_flex(struct context *ctx, const struct token *token,
switch (ctx->curr) {
default:
break;
- case FLEX_ITEM_INIT:
case FLEX_ITEM_CREATE:
case FLEX_ITEM_DESTROY:
out->command = ctx->curr;
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-11-11 14:23:10.191913637 +0800
+++ 0109-app-testpmd-remove-flex-item-init-command-leftover.patch 2024-11-11 14:23:05.322192836 +0800
@@ -1 +1 @@
-From d5c50397a1cc06419970afbea9cd1c37e3c08a5b Mon Sep 17 00:00:00 2001
+From 179f82ff012e353903bad9c9b0451b09c6941600 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit d5c50397a1cc06419970afbea9cd1c37e3c08a5b ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index 5451b3a453..5f71e5ba44 100644
+index 7e6e06a04f..4b13d84ad1 100644
@@ -23 +25 @@
-@@ -106,7 +106,6 @@ enum index {
+@@ -105,7 +105,6 @@ enum index {
@@ -31 +33 @@
-@@ -1320,7 +1319,6 @@ struct parse_action_priv {
+@@ -1249,7 +1248,6 @@ struct parse_action_priv {
@@ -39 +41 @@
-@@ -4188,15 +4186,6 @@ static const struct token token_list[] = {
+@@ -3932,15 +3930,6 @@ static const struct token token_list[] = {
@@ -55 +57 @@
-@@ -11472,7 +11461,6 @@ parse_flex(struct context *ctx, const struct token *token,
+@@ -10720,7 +10709,6 @@ parse_flex(struct context *ctx, const struct token *token,
More information about the stable
mailing list