patch 'net/ixgbe: fix link status delay on FreeBSD' has been queued to stable release 22.11.7

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Nov 12 23:07:15 CET 2024


Hi,

FYI, your patch has been queued to stable release 22.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/14/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/a4ee1170efdafa7e38b42b4f9974795bbacb2f8b

Thanks.

Luca Boccassi

---
>From a4ee1170efdafa7e38b42b4f9974795bbacb2f8b Mon Sep 17 00:00:00 2001
From: Lewis Donzis <lew at perftech.com>
Date: Tue, 22 Oct 2024 09:42:05 -0500
Subject: [PATCH] net/ixgbe: fix link status delay on FreeBSD

[ upstream commit f775386d92d68e534600fcff3fc4bcaa30d3e68c ]

Forcing wait true prevents checking link status without delay, because
the function will wait more than 10 seconds for link status to be true,
even if the API caller requested no waiting.

Fixes: 0012111a3d87 ("net/ixgbe: fix link status synchronization on BSD")

Signed-off-by: Lewis Donzis <lew at perftech.com>
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 9e1a65a50a..99986aa1d4 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4302,11 +4302,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
 	if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0)
 		wait = 0;
 
-/* BSD has no interrupt mechanism, so force NIC status synchronization. */
-#ifdef RTE_EXEC_ENV_FREEBSD
-	wait = 1;
-#endif
-
 	if (vf)
 		diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);
 	else
-- 
2.45.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-11-12 22:06:58.855499459 +0000
+++ 0005-net-ixgbe-fix-link-status-delay-on-FreeBSD.patch	2024-11-12 22:06:58.635306699 +0000
@@ -1 +1 @@
-From f775386d92d68e534600fcff3fc4bcaa30d3e68c Mon Sep 17 00:00:00 2001
+From a4ee1170efdafa7e38b42b4f9974795bbacb2f8b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit f775386d92d68e534600fcff3fc4bcaa30d3e68c ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index ab37c37469..008760e315 100644
+index 9e1a65a50a..99986aa1d4 100644
@@ -23 +24 @@
-@@ -4314,11 +4314,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
+@@ -4302,11 +4302,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,


More information about the stable mailing list