patch 'app/dumpcap: remove unused struct array' has been queued to stable release 22.11.7

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 22.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/14/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/381787b7df76e0f15992219ed2519fc67e58f95a

Thanks.

Luca Boccassi

---
>From 381787b7df76e0f15992219ed2519fc67e58f95a Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Tue, 5 Nov 2024 11:27:21 +0000
Subject: [PATCH] app/dumpcap: remove unused struct array

[ upstream commit 9bbd44d63846cf0771ec0f1c7e1b5a63ec5e9603 ]

The callbacks(rx_cb) member of struct interface was unused inside
dumpcap, but was taking up a lot of memory space, since it was scaled
according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save
memory by removing the whole array.

Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")

Suggested-by: Stephen Hemminger <stephen at networkplumber.org>
Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
---
 app/dumpcap/main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index 7e8aa5d76e..0b6432ad4d 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -83,8 +83,6 @@ struct interface {
 	TAILQ_ENTRY(interface) next;
 	uint16_t port;
 	char name[RTE_ETH_NAME_MAX_LEN];
-
-	struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT];
 };
 
 TAILQ_HEAD(interface_list, interface);
-- 
2.45.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-11-12 22:06:59.181291544 +0000
+++ 0015-app-dumpcap-remove-unused-struct-array.patch	2024-11-12 22:06:58.659307077 +0000
@@ -1 +1 @@
-From 9bbd44d63846cf0771ec0f1c7e1b5a63ec5e9603 Mon Sep 17 00:00:00 2001
+From 381787b7df76e0f15992219ed2519fc67e58f95a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 9bbd44d63846cf0771ec0f1c7e1b5a63ec5e9603 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -18,2 +19,2 @@
- app/dumpcap/main.c | 1 -
- 1 file changed, 1 deletion(-)
+ app/dumpcap/main.c | 2 --
+ 1 file changed, 2 deletions(-)
@@ -22 +23 @@
-index 4031f48441..3d3c0dbc66 100644
+index 7e8aa5d76e..0b6432ad4d 100644
@@ -25,2 +26,3 @@
-@@ -96,7 +96,6 @@ struct interface {
- 	struct rte_bpf_prm *bpf_prm;
+@@ -83,8 +83,6 @@ struct interface {
+ 	TAILQ_ENTRY(interface) next;
+ 	uint16_t port;
@@ -28 +30 @@
- 
+-
@@ -30,2 +31,0 @@
- 	const char *ifname;
- 	const char *ifdescr;
@@ -32,0 +33,2 @@
+ 
+ TAILQ_HEAD(interface_list, interface);