[PATCH 1/2] bus/dpaa: fix lock condition during error handling
Hemant Agrawal
hemant.agrawal at oss.nxp.com
Thu Nov 14 08:45:52 CET 2024
On 13-11-2024 22:18, David Marchand wrote:
> Hello Hemant,
>
> On Wed, Nov 13, 2024 at 5:15 PM Hemant Agrawal <hemant.agrawal at nxp.com> wrote:
>> The error handling is missing FQ unlock code.
>> Detected by pvr-studio
>> Bug 89-93: very suspicious synchronization
>> The analyzer issued a pack of V1020 warnings that a resource
>> might remain blocked.
>>
>> Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
> The fix looks good to me.
>
> To avoid regressions on this topic, could you look into enabling clang
> thread safety check?
>
> I suppose that FQLOCK and FQUNLOCK always come in pairs (seems a safe
> assumption), so enabling should be something like:
Thanks for the suggestion and code snippet. It looks good.
More information about the stable
mailing list